diff options
| author | Phil Hughes <me@iamphill.com> | 2016-05-20 09:20:35 +0100 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2016-05-20 09:20:35 +0100 |
| commit | fac08c3bcd7316794bcbcfb5cec32ac05cb104fe (patch) | |
| tree | df776d8d127fa38e3a9845bba7e6db514727d08b | |
| parent | 7df4b16b56f52eafccd080253b60a4cc15c66149 (diff) | |
| download | gitlab-ce-fac08c3bcd7316794bcbcfb5cec32ac05cb104fe.tar.gz | |
Fixed up JS comments
| -rw-r--r-- | app/assets/javascripts/issuable.js.coffee | 5 | ||||
| -rw-r--r-- | app/assets/javascripts/lib/url_utility.js.coffee | 4 |
2 files changed, 4 insertions, 5 deletions
diff --git a/app/assets/javascripts/issuable.js.coffee b/app/assets/javascripts/issuable.js.coffee index 4c4f67f5104..6cb5d86fb93 100644 --- a/app/assets/javascripts/issuable.js.coffee +++ b/app/assets/javascripts/issuable.js.coffee @@ -106,9 +106,8 @@ issuable_created = false checkChanged: -> checked_issues = $('.selected_issue:checked') if checked_issues.length > 0 - ids = [] - $.each checked_issues, (index, value) -> - ids.push $(value).data('id') + ids = $.map checked_issues, (value) -> + $(value).data('id') $('#update_issues_ids').val ids $('.issues-other-filters').hide() diff --git a/app/assets/javascripts/lib/url_utility.js.coffee b/app/assets/javascripts/lib/url_utility.js.coffee index 3d51744614f..e8085e1c2e4 100644 --- a/app/assets/javascripts/lib/url_utility.js.coffee +++ b/app/assets/javascripts/lib/url_utility.js.coffee @@ -26,9 +26,9 @@ newUrl = decodeURIComponent(url) for paramName, paramValue of params pattern = new RegExp "\\b(#{paramName}=).*?(&|$)" - if !paramValue? + if not paramValue? newUrl = newUrl.replace pattern, '' - else if url.search(pattern) >= 0 + else if url.search(pattern) isnt -1 newUrl = newUrl.replace pattern, "$1#{paramValue}$2" else newUrl = "#{newUrl}#{(if newUrl.indexOf('?') > 0 then '&' else '?')}#{paramName}=#{paramValue}" |