diff options
| author | Achilleas Pipinellis <axilleas@axilleas.me> | 2016-08-12 09:47:49 +0000 |
|---|---|---|
| committer | Achilleas Pipinellis <axilleas@axilleas.me> | 2016-08-12 09:47:49 +0000 |
| commit | b2828d4145ac01468a59b821ced29dd248526089 (patch) | |
| tree | 91223b5de622e0c514db8db0183bdc8585625649 | |
| parent | 0f6ed843b20ed64d25ee5fda7243611f3654e43e (diff) | |
| parent | 7d65d2ec2b808a796efdada83cd0ec3613ca693b (diff) | |
| download | gitlab-ce-b2828d4145ac01468a59b821ced29dd248526089.tar.gz | |
Merge branch 'update-performance-guide' into 'master'
Corrected links/usernames in performance guide
## What does this MR do?
This fixes two broken links in the performance guide and removes the mention of Josh as he no longer works for GitLab.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
The guide contained two broken links, and Josh no longer works for GitLab.
## What are the relevant issue numbers?
None.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5772
| -rw-r--r-- | doc/development/performance.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/doc/development/performance.md b/doc/development/performance.md index fb37b3a889c..7ff603e2c4a 100644 --- a/doc/development/performance.md +++ b/doc/development/performance.md @@ -15,8 +15,8 @@ The process of solving performance problems is roughly as follows: 3. Add your findings based on the measurement period (screenshots of graphs, timings, etc) to the issue mentioned in step 1. 4. Solve the problem. -5. Create a merge request, assign the "performance" label and ping the right - people (e.g. [@yorickpeterse][yorickpeterse] and [@joshfng][joshfng]). +5. Create a merge request, assign the "Performance" label and assign it to + [@yorickpeterse][yorickpeterse] for reviewing. 6. Once a change has been deployed make sure to _again_ measure for at least 24 hours to see if your changes have any impact on the production environment. 7. Repeat until you're done. @@ -36,8 +36,8 @@ graphs/dashboards. GitLab provides two built-in tools to aid the process of improving performance: -* [Sherlock](doc/development/profiling.md#sherlock) -* [GitLab Performance Monitoring](doc/monitoring/performance/monitoring.md) +* [Sherlock](profiling.md#sherlock) +* [GitLab Performance Monitoring](../monitoring/performance/monitoring.md) GitLab employees can use GitLab.com's performance monitoring systems located at <http://performance.gitlab.net>, this requires you to log in using your @@ -254,5 +254,4 @@ referencing an object directly may even slow code down. [#15607]: https://gitlab.com/gitlab-org/gitlab-ce/issues/15607 [yorickpeterse]: https://gitlab.com/u/yorickpeterse -[joshfng]: https://gitlab.com/u/joshfng [anti-pattern]: https://en.wikipedia.org/wiki/Anti-pattern |