diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-08-19 09:24:51 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-08-19 09:24:51 +0000 |
| commit | b99f84119708cecab02dd3691febdf285a384b96 (patch) | |
| tree | 342f0133b522ba2603a66fefcd3c774708a7090c | |
| parent | 15bbab880eb9673b8120f6a34f3c145a88a58a53 (diff) | |
| download | gitlab-ce-b99f84119708cecab02dd3691febdf285a384b96.tar.gz | |
Update contribution acceptance criteria with tests requirementsdz-test-required
| -rw-r--r-- | CONTRIBUTING.md | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b393e4157a9..d8093a61b4c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -387,9 +387,8 @@ description area. Copy-paste it to retain the markdown format. 1. The change is as small as possible 1. Include proper tests and make all tests pass (unless it contains a test - exposing a bug in existing code). Every new file with code you created - must have a corresponging file with tests even if functionality is - already tested somewhere else. + exposing a bug in existing code). Every new class should have corresponding + unit tests, even if the class is exercised at a higher level, such as a feature test. 1. If you suspect a failing CI build is unrelated to your contribution, you may try and restart the failing CI job or ask a developer to fix the aforementioned failing test |