diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-10-20 21:43:24 -0700 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-10-21 12:45:10 +0200 |
| commit | b332931af375a29fa0ff41d45315400beca44c7a (patch) | |
| tree | 2406ec6525f80c2257037aaebb743a56aef06f2a | |
| parent | e647af363706d181557e7652cacc19cd7c54dd59 (diff) | |
| download | gitlab-ce-b332931af375a29fa0ff41d45315400beca44c7a.tar.gz | |
Fix broken label uniqueness label migration
The previous implementation of the migration failed on staging because
the migration was attempted to remove labels from projects that did not
actually have duplicates. This occurred because the SQL query did not
account for the project ID when selecting the labels.
To replicate the problem:
1. Disable the uniqueness validation in app/models/label.rb.
2. Create a duplicate label "bug" in project A.
3. Create the same label in project B with label "bug".
The migration will attempt to remove the label in B even if there are no duplicates.
Closes #23609
| -rw-r--r-- | db/migrate/20161017125927_add_unique_index_to_labels.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/db/migrate/20161017125927_add_unique_index_to_labels.rb b/db/migrate/20161017125927_add_unique_index_to_labels.rb index 16ae38612de..f2b56ebfb7b 100644 --- a/db/migrate/20161017125927_add_unique_index_to_labels.rb +++ b/db/migrate/20161017125927_add_unique_index_to_labels.rb @@ -7,9 +7,9 @@ class AddUniqueIndexToLabels < ActiveRecord::Migration disable_ddl_transaction! def up - select_all('SELECT title, COUNT(id) as cnt FROM labels GROUP BY project_id, title HAVING COUNT(id) > 1').each do |label| + select_all('SELECT title, project_id, COUNT(id) as cnt FROM labels GROUP BY project_id, title HAVING COUNT(id) > 1').each do |label| label_title = quote_string(label['title']) - duplicated_ids = select_all("SELECT id FROM labels WHERE title = '#{label_title}' ORDER BY id ASC").map{ |label| label['id'] } + duplicated_ids = select_all("SELECT id FROM labels WHERE project_id = #{label['project_id']} AND title = '#{label_title}' ORDER BY id ASC").map{ |label| label['id'] } label_id = duplicated_ids.first duplicated_ids.delete(label_id) |