diff options
author | Rémy Coutable <remy@rymai.me> | 2018-02-13 18:20:01 +0100 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-02-14 14:37:49 +0100 |
commit | 539b3a3532bae17b8f9ce48628046ee43812f5ec (patch) | |
tree | dda248d98efea6a47f4988e52901275cf8bb8a72 | |
parent | e7595c10bc14cd32c456b9c6a94e227d41d6d09a (diff) | |
download | gitlab-ce-539b3a3532bae17b8f9ce48628046ee43812f5ec.tar.gz |
Fix a too strict array-matching expectation
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r-- | spec/requests/openid_connect_spec.rb | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/spec/requests/openid_connect_spec.rb b/spec/requests/openid_connect_spec.rb index 5d349f45a33..de829011e58 100644 --- a/spec/requests/openid_connect_spec.rb +++ b/spec/requests/openid_connect_spec.rb @@ -81,7 +81,7 @@ describe 'OpenID Connect requests' do it 'includes all user information and group memberships' do request_user_info - expect(json_response).to eq({ + expect(json_response).to match(a_hash_including({ 'sub' => hashed_subject, 'name' => 'Alice', 'nickname' => 'alice', @@ -90,13 +90,12 @@ describe 'OpenID Connect requests' do 'website' => 'https://example.com', 'profile' => 'http://localhost/alice', 'picture' => "http://localhost/uploads/-/system/user/avatar/#{user.id}/dk.png", - 'groups' => - if Group.supports_nested_groups? - ['group1', 'group2/group3', 'group2/group3/group4'] - else - ['group1', 'group2/group3'] - end - }) + 'groups' => anything + })) + + expected_groups = %w[group1 group2/group3] + expected_groups << 'group2/group3/group4' if Group.supports_nested_groups? + expect(json_response['groups']).to match_array(expected_groups) end end |