summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzegorz@gitlab.com>2017-08-08 11:52:51 +0000
committerGrzegorz Bizon <grzegorz@gitlab.com>2017-08-08 11:52:51 +0000
commit2b781c782de19b99526a649df5595e4161a84dc7 (patch)
tree60465f50c1baa992d19d8e7c1a935c1e54a0d77b
parent356c8b3851b42d88986202f65781b765708e343f (diff)
parentb3537000aaf3bf0de98adec938bd19e97bf8b3d6 (diff)
downloadgitlab-ce-2b781c782de19b99526a649df5595e4161a84dc7.tar.gz
Merge branch 'winh-scope-haml-linter' into 'master'
Restrict InlineJavaScript for haml_lint to dev and test environment Closes omnibus-gitlab#2658 See merge request !13364
-rw-r--r--lib/haml_lint/inline_javascript.rb20
1 files changed, 11 insertions, 9 deletions
diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb
index f3ddcbb9c95..05668c69006 100644
--- a/lib/haml_lint/inline_javascript.rb
+++ b/lib/haml_lint/inline_javascript.rb
@@ -1,14 +1,16 @@
-require 'haml_lint/haml_visitor'
-require 'haml_lint/linter'
-require 'haml_lint/linter_registry'
+unless Rails.env.production?
+ require 'haml_lint/haml_visitor'
+ require 'haml_lint/linter'
+ require 'haml_lint/linter_registry'
-module HamlLint
- class Linter::InlineJavaScript < Linter
- include LinterRegistry
+ module HamlLint
+ class Linter::InlineJavaScript < Linter
+ include LinterRegistry
- def visit_filter(node)
- return unless node.filter_type == 'javascript'
- record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
+ def visit_filter(node)
+ return unless node.filter_type == 'javascript'
+ record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
+ end
end
end
end