summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJose Corcuera <jzcorcuera@gmail.com>2015-11-20 23:55:17 -0500
committerJose Corcuera <jzcorcuera@gmail.com>2015-11-20 23:55:17 -0500
commitbe045553ea4115853847cfcb8a0a40f2a3d7c4a2 (patch)
tree3f5e863a4301c01995e4e316ebf6f8f12847015b
parent94b90db5479a4536d459d8e6beaeaea376f6b356 (diff)
downloadgitlab-ce-be045553ea4115853847cfcb8a0a40f2a3d7c4a2.tar.gz
Fix Assignee selector when 'Unassigned' #2831
-rw-r--r--CHANGELOG1
-rw-r--r--app/assets/javascripts/users_select.js.coffee15
2 files changed, 11 insertions, 5 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 75e5b7585f9..fc7b6e75b1d 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,6 +1,7 @@
Please view this file on the master branch, on stable branches it's out of date.
v 8.3.0 (unreleased)
+ - Fix: Assignee selector is empty when 'Unassigned' is selected (Jose Corcuera)
v 8.2.0
- Improved performance of finding projects and groups in various places
diff --git a/app/assets/javascripts/users_select.js.coffee b/app/assets/javascripts/users_select.js.coffee
index 9157562a5c5..f5db74d84e7 100644
--- a/app/assets/javascripts/users_select.js.coffee
+++ b/app/assets/javascripts/users_select.js.coffee
@@ -58,11 +58,8 @@ class @UsersSelect
query.callback(data)
- initSelection: (element, callback) =>
- id = $(element).val()
- if id != "" && id != "0"
- @user(id, callback)
-
+ initSelection: (args...) =>
+ @initSelection(args...)
formatResult: (args...) =>
@formatResult(args...)
formatSelection: (args...) =>
@@ -71,6 +68,14 @@ class @UsersSelect
escapeMarkup: (m) -> # we do not want to escape markup since we are displaying html in results
m
+ initSelection: (element, callback) ->
+ id = $(element).val()
+ if id == "0"
+ nullUser = { name: 'Unassigned' }
+ callback(nullUser)
+ else if id != ""
+ @user(id, callback)
+
formatResult: (user) ->
if user.avatar_url
avatar = user.avatar_url