summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexis Reigel <alexis.reigel.ext@siemens.com>2018-02-26 15:10:48 +0100
committerAlexis Reigel <alexis.reigel.ext@siemens.com>2018-02-28 09:52:43 +0100
commit6b022acbf03a4801e9b3315c0ad8b6f0ad5d921d (patch)
tree426d654caeaedd07be1be4e47125a53df0ded295
parent05862448cae656ec93d091d9ca719f66297f2a0d (diff)
downloadgitlab-ce-6b022acbf03a4801e9b3315c0ad8b6f0ad5d921d.tar.gz
use more efficient AR length check methods
-rw-r--r--app/models/ci/runner.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/models/ci/runner.rb b/app/models/ci/runner.rb
index 3b1f109374e..fb2f3c56b51 100644
--- a/app/models/ci/runner.rb
+++ b/app/models/ci/runner.rb
@@ -246,11 +246,11 @@ module Ci
end
def either_projects_or_group
- if groups.length > 1
+ if groups.many?
errors.add(:runner, 'can only be assigned to one group')
end
- if groups.length > 0 && projects.length > 0
+ if group? && project?
errors.add(:runner, 'can only be assigned either to projects or to a group')
end
end