diff options
author | Alexis Reigel <alexis.reigel.ext@siemens.com> | 2017-10-30 16:17:17 +0100 |
---|---|---|
committer | Alexis Reigel <alexis.reigel.ext@siemens.com> | 2018-02-28 09:50:52 +0100 |
commit | 831ee19de9cdc9b600b88dab90cad1d09920ce9f (patch) | |
tree | 8f15137e2b8c209895907a648c1a3ff800f6dab5 | |
parent | 5410a84b2ecafb0121f34f8482f66d00d65ee8af (diff) | |
download | gitlab-ce-831ee19de9cdc9b600b88dab90cad1d09920ce9f.tar.gz |
dry up: extract method
-rw-r--r-- | app/services/ci/update_build_queue_service.rb | 26 |
1 files changed, 11 insertions, 15 deletions
diff --git a/app/services/ci/update_build_queue_service.rb b/app/services/ci/update_build_queue_service.rb index 4fb03d2fa1b..ab81766abf3 100644 --- a/app/services/ci/update_build_queue_service.rb +++ b/app/services/ci/update_build_queue_service.rb @@ -1,26 +1,22 @@ module Ci class UpdateBuildQueueService def execute(build) - build.project.runners.each do |runner| - if runner.can_pick?(build) - runner.tick_runner_queue - end - end + tick_for(build, build.project.runners) if build.project.group_runners_enabled? - Ci::Runner.belonging_to_group(build.project_id).each do |runner| - if runner.can_pick?(build) - runner.tick_runner_queue - end - end + tick_for(build, Ci::Runner.belonging_to_group(build.project_id)) end if build.project.shared_runners_enabled? - Ci::Runner.shared.each do |runner| - if runner.can_pick?(build) - runner.tick_runner_queue - end - end + tick_for(build, Ci::Runner.shared) + end + end + + private + + def tick_for(build, runners) + runners.each do |runner| + runner.tick_runner_queue if runner.can_pick?(build) end end end |