diff options
| author | Benedikt Huss <benedikt.huss@gmail.com> | 2016-05-05 01:16:16 +0200 |
|---|---|---|
| committer | Benedikt Huss <benedikt.huss@gmail.com> | 2016-05-10 00:37:15 +0200 |
| commit | bf0fd3ea1bcbf0245c973411d8e5b28a15ef206f (patch) | |
| tree | b794af5ac171eb76063e395507e5834fb07c7f02 | |
| parent | 93b4a3a1561839f42b03755b071296b926f6e7a5 (diff) | |
| download | gitlab-ce-bf0fd3ea1bcbf0245c973411d8e5b28a15ef206f.tar.gz | |
Links for redmine issue references are generated correctly again
| -rw-r--r-- | CHANGELOG | 1 | ||||
| -rw-r--r-- | lib/banzai/filter/issue_reference_filter.rb | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 63077523aaa..1c6e24bc10f 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -40,6 +40,7 @@ v 8.8.0 (unreleased) v 8.7.4 - Fix always showing build notification message when switching between merge requests - Fix links on wiki pages for relative url setups. !4026 (Artem Sidorenko) + - Links for Redmine issue references are generated correctly again (Benedikt Huss) v 8.7.3 - Emails, Gitlab::Email::Message, Gitlab::Diff, and Premailer::Adapter::Nokogiri are now instrumented diff --git a/lib/banzai/filter/issue_reference_filter.rb b/lib/banzai/filter/issue_reference_filter.rb index 2732e0b5145..59c5e89c546 100644 --- a/lib/banzai/filter/issue_reference_filter.rb +++ b/lib/banzai/filter/issue_reference_filter.rb @@ -10,6 +10,9 @@ module Banzai end def self.user_can_see_reference?(user, node, context) + # It is not possible to check access rights for external issue trackers + return true if context[:project].try(:external_issue_tracker) + issue = Issue.find(node.attr('data-issue')) rescue nil Ability.abilities.allowed?(user, :read_issue, issue) end |