diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-24 09:49:54 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-24 09:49:54 +0200 |
commit | e017e1b62904fe323be359f1ac406c951dcd4ccd (patch) | |
tree | 1d482d023c1475e5e97059a60f6a3633ea2c4b02 | |
parent | 04ece6664a04e7c352582100bdd6e8d78c3ea7cc (diff) | |
download | gitlab-ce-e017e1b62904fe323be359f1ac406c951dcd4ccd.tar.gz |
Add ci config class that represents a boolean value
-rw-r--r-- | lib/gitlab/ci/config/node/boolean.rb | 18 | ||||
-rw-r--r-- | lib/gitlab/ci/config/node/validators.rb | 10 | ||||
-rw-r--r-- | spec/lib/gitlab/ci/config/node/boolean_spec.rb | 34 |
3 files changed, 62 insertions, 0 deletions
diff --git a/lib/gitlab/ci/config/node/boolean.rb b/lib/gitlab/ci/config/node/boolean.rb new file mode 100644 index 00000000000..84b03ee7832 --- /dev/null +++ b/lib/gitlab/ci/config/node/boolean.rb @@ -0,0 +1,18 @@ +module Gitlab + module Ci + class Config + module Node + ## + # Entry that represents a boolean value. + # + class Boolean < Entry + include Validatable + + validations do + validates :config, boolean: true + end + end + end + end + end +end diff --git a/lib/gitlab/ci/config/node/validators.rb b/lib/gitlab/ci/config/node/validators.rb index f2b3a8a3f81..4082c161e81 100644 --- a/lib/gitlab/ci/config/node/validators.rb +++ b/lib/gitlab/ci/config/node/validators.rb @@ -13,6 +13,16 @@ module Gitlab end end + class BooleanValidator < ActiveModel::EachValidator + include LegacyValidationHelpers + + def validate_each(record, attribute, value) + unless validate_boolean(value) + record.errors.add(attribute, 'should be a boolean value') + end + end + end + class KeyValidator < ActiveModel::EachValidator include LegacyValidationHelpers diff --git a/spec/lib/gitlab/ci/config/node/boolean_spec.rb b/spec/lib/gitlab/ci/config/node/boolean_spec.rb new file mode 100644 index 00000000000..97f13b2d5fc --- /dev/null +++ b/spec/lib/gitlab/ci/config/node/boolean_spec.rb @@ -0,0 +1,34 @@ +require 'spec_helper' + +describe Gitlab::Ci::Config::Node::Boolean do + let(:entry) { described_class.new(config) } + + describe 'validations' do + context 'when entry config value is valid' do + let(:config) { false } + + describe '#value' do + it 'returns key value' do + expect(entry.value).to eq false + end + end + + describe '#valid?' do + it 'is valid' do + expect(entry).to be_valid + end + end + end + + context 'when entry value is not valid' do + let(:config) { [ 'incorrect' ] } + + describe '#errors' do + it 'saves errors' do + expect(entry.errors) + .to include 'Boolean config should be a boolean value' + end + end + end + end +end |