diff options
author | Andreas Brandl <abrandl@gitlab.com> | 2018-03-05 17:47:27 +0100 |
---|---|---|
committer | Andreas Brandl <abrandl@gitlab.com> | 2018-03-06 12:53:15 +0100 |
commit | 8e668076a975447a662bf8927388ce55f7d22dba (patch) | |
tree | 75737e68ddd06d83b11cd64282346fbad92e3708 | |
parent | d270b857341efe6d878f3c23ca8707608c97d9d9 (diff) | |
download | gitlab-ce-8e668076a975447a662bf8927388ce55f7d22dba.tar.gz |
Improve robustness of migration.
-rw-r--r-- | db/post_migrate/20180223124427_build_user_interacted_projects_table.rb | 45 |
1 files changed, 39 insertions, 6 deletions
diff --git a/db/post_migrate/20180223124427_build_user_interacted_projects_table.rb b/db/post_migrate/20180223124427_build_user_interacted_projects_table.rb index 4d14dc7b4fb..5e729b1aa53 100644 --- a/db/post_migrate/20180223124427_build_user_interacted_projects_table.rb +++ b/db/post_migrate/20180223124427_build_user_interacted_projects_table.rb @@ -13,23 +13,56 @@ class BuildUserInteractedProjectsTable < ActiveRecord::Migration MysqlStrategy.new end.up - add_concurrent_index :user_interacted_projects, [:project_id, :user_id], unique: true + unless index_exists?(:user_interacted_projects, [:project_id, :user_id]) + add_concurrent_index :user_interacted_projects, [:project_id, :user_id], unique: true + end + + unless foreign_key_exists?(:user_interacted_projects, :user_id) + add_concurrent_foreign_key :user_interacted_projects, :users, column: :user_id, on_delete: :cascade + end - add_concurrent_foreign_key :user_interacted_projects, :users, column: :user_id, on_delete: :cascade - add_concurrent_foreign_key :user_interacted_projects, :projects, column: :project_id, on_delete: :cascade + unless foreign_key_exists?(:user_interacted_projects, :project_id) + add_concurrent_foreign_key :user_interacted_projects, :projects, column: :project_id, on_delete: :cascade + end end def down execute "TRUNCATE user_interacted_projects" - remove_foreign_key :user_interacted_projects, :users - remove_foreign_key :user_interacted_projects, :projects + if foreign_key_exists?(:user_interacted_projects, :user_id) + remove_foreign_key :user_interacted_projects, :users + end + + if foreign_key_exists?(:user_interacted_projects, :project_id) + remove_foreign_key :user_interacted_projects, :projects + end - remove_concurrent_index_by_name :user_interacted_projects, 'index_user_interacted_projects_on_project_id_and_user_id' + if index_exists_by_name?(:user_interacted_projects, 'index_user_interacted_projects_on_project_id_and_user_id') + remove_concurrent_index_by_name :user_interacted_projects, 'index_user_interacted_projects_on_project_id_and_user_id' + end end private + # Rails' index_exists? doesn't work when you only give it a table and index + # name. As such we have to use some extra code to check if an index exists for + # a given name. + def index_exists_by_name?(table, index) + indexes_for_table[table].include?(index) + end + + def indexes_for_table + @indexes_for_table ||= Hash.new do |hash, table_name| + hash[table_name] = indexes(table_name).map(&:name) + end + end + + def foreign_key_exists?(table, column) + foreign_keys(table).any? do |key| + key.options[:column] == column.to_s + end + end + class PostgresStrategy < ActiveRecord::Migration include Gitlab::Database::MigrationHelpers |