diff options
| author | Douwe Maan <douwe@gitlab.com> | 2016-03-01 13:52:49 +0000 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2016-03-01 13:52:49 +0000 |
| commit | c50a20e7903ac1ed0179dda134cb41dbb97d60df (patch) | |
| tree | 5cf6a071db848116cbb3ebbba87ff796acaf0328 | |
| parent | fac1e0e83c6abcca5238bd94fe10261e3bff6257 (diff) | |
| parent | a310901280161985ba1680e7923eb917f8deec35 (diff) | |
| download | gitlab-ce-c50a20e7903ac1ed0179dda134cb41dbb97d60df.tar.gz | |
Merge branch 'comment-batch-size' into 'master'
Batch size >1000 does not pay off
We did a small experiment to see how a full scan of the Redis keys on
gitlab.com speeds up as we increase the batch size. The values on the
right are time in seconds for a full scan (no delete operations).
```
count: 10); 284.500529021
count: 100); 86.21216934
count: 1_000); 60.931676195
count: 10_000); 60.96355610
count: 100_000); 62.378172541
```
It looks like 1,000 is a good number.
See merge request !2970
| -rw-r--r-- | lib/tasks/cache.rake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/tasks/cache.rake b/lib/tasks/cache.rake index 9e2fb429d57..f221afcf73a 100644 --- a/lib/tasks/cache.rake +++ b/lib/tasks/cache.rake @@ -1,5 +1,5 @@ namespace :cache do - CLEAR_BATCH_SIZE = 1000 # The more the faster, but having too many can crash Ruby + CLEAR_BATCH_SIZE = 1000 # There seems to be no speedup when pushing beyond 1,000 REDIS_SCAN_START_STOP = '0' # Magic value, see http://redis.io/commands/scan desc "GitLab | Clear redis cache" |