summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-10-10 20:41:52 +0000
committerLin Jen-Shin <godfat@godfat.org>2017-10-13 20:36:41 +0800
commitc88e4979aa247028f3de41ba27fe1848e3e90ddd (patch)
treeac400ba015dd8c815d981481b74e192bff778695
parent946635c262ecc0b3cc16c858ca24f60ff3fbc357 (diff)
downloadgitlab-ce-c88e4979aa247028f3de41ba27fe1848e3e90ddd.tar.gz
Merge branch 'add-resolve-discussion-test' into 'master'
Add explicit test to test resolved discussion toggle content See merge request gitlab-org/gitlab-ce!14796
-rw-r--r--spec/features/merge_requests/diff_notes_resolve_spec.rb20
1 files changed, 15 insertions, 5 deletions
diff --git a/spec/features/merge_requests/diff_notes_resolve_spec.rb b/spec/features/merge_requests/diff_notes_resolve_spec.rb
index 637e6036384..475c8586f45 100644
--- a/spec/features/merge_requests/diff_notes_resolve_spec.rb
+++ b/spec/features/merge_requests/diff_notes_resolve_spec.rb
@@ -88,14 +88,24 @@ feature 'Diff notes resolve', :js do
end
end
- it 'hides resolved discussion' do
- page.within '.diff-content' do
- click_button 'Resolve discussion'
+ describe 'resolved discussion' do
+ before do
+ page.within '.diff-content' do
+ click_button 'Resolve discussion'
+ end
+
+ visit_merge_request
end
- visit_merge_request
+ it 'hides when resolve discussion is clicked' do
+ expect(page).to have_selector('.discussion-body', visible: false)
+ end
- expect(page).to have_selector('.discussion-body', visible: false)
+ it 'shows resolved discussion when toggled' do
+ find(".timeline-content .discussion[data-discussion-id='#{note.discussion_id}'] .discussion-toggle-button").click
+
+ expect(page.find(".timeline-content #note_#{note.noteable_id}")).to be_visible
+ end
end
it 'allows user to resolve from reply form without a comment' do