summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2017-04-07 20:23:13 -0400
committerRobert Speicher <rspeicher@gmail.com>2017-04-07 20:23:13 -0400
commit6576a6ce929f284cbe127e5a2c082dd52856f769 (patch)
tree48af9c432ad002ce2b1a25aa6dece5d6d4293d37
parent86a2fb2fe626e5d627710d5c32e03d640c624102 (diff)
downloadgitlab-ce-6576a6ce929f284cbe127e5a2c082dd52856f769.tar.gz
Enable RSpec/DescribeSymbol; update .rubocop_todo.yml
-rw-r--r--.rubocop.yml4
-rw-r--r--.rubocop_todo.yml126
2 files changed, 80 insertions, 50 deletions
diff --git a/.rubocop.yml b/.rubocop.yml
index ac6b141cea3..e5549b64503 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -954,6 +954,10 @@ RSpec/DescribeClass:
RSpec/DescribeMethod:
Enabled: false
+# Avoid describing symbols.
+RSpec/DescribeSymbol:
+ Enabled: true
+
# Checks that the second argument to top level describe is the tested method
# name.
RSpec/DescribedClass:
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 8588988dc87..38b22afdf82 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,12 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 0`
-# on 2017-02-22 13:02:35 -0600 using RuboCop version 0.47.1.
+# on 2017-04-07 20:17:35 -0400 using RuboCop version 0.47.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 51
+# Offense count: 54
RSpec/BeforeAfterAll:
Enabled: false
@@ -15,11 +15,19 @@ RSpec/BeforeAfterAll:
RSpec/EmptyExampleGroup:
Enabled: false
-# Offense count: 1
+# Offense count: 233
+RSpec/EmptyLineAfterFinalLet:
+ Enabled: false
+
+# Offense count: 167
+RSpec/EmptyLineAfterSubject:
+ Enabled: false
+
+# Offense count: 3
RSpec/ExpectOutput:
Enabled: false
-# Offense count: 63
+# Offense count: 72
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
@@ -31,19 +39,37 @@ RSpec/HookArgument:
RSpec/ImplicitExpect:
Enabled: false
-# Offense count: 36
-RSpec/RepeatedExample:
+# Offense count: 11
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: it_behaves_like, it_should_behave_like
+RSpec/ItBehavesLike:
+ Enabled: false
+
+# Offense count: 4
+RSpec/IteratedExpectation:
+ Enabled: false
+
+# Offense count: 3
+RSpec/OverwritingSetup:
Enabled: false
# Offense count: 34
+RSpec/RepeatedExample:
+ Enabled: false
+
+# Offense count: 43
+RSpec/ScatteredLet:
+ Enabled: false
+
+# Offense count: 32
RSpec/ScatteredSetup:
Enabled: false
# Offense count: 1
-RSpec/SingleArgumentMessageChain:
+RSpec/SharedContext:
Enabled: false
-# Offense count: 163
+# Offense count: 150
Rails/FilePath:
Enabled: false
@@ -53,7 +79,7 @@ Rails/FilePath:
Rails/ReversibleMigration:
Enabled: false
-# Offense count: 278
+# Offense count: 302
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
@@ -64,26 +90,26 @@ Rails/SkipsModelValidations:
Security/YAMLLoad:
Enabled: false
-# Offense count: 55
+# Offense count: 59
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
Enabled: false
-# Offense count: 1304
+# Offense count: 1403
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
Style/DotPosition:
Enabled: false
-# Offense count: 6
+# Offense count: 5
# Cop supports --auto-correct.
Style/EachWithObject:
Enabled: false
-# Offense count: 25
+# Offense count: 28
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
@@ -95,72 +121,72 @@ Style/EmptyElse:
Style/EmptyLiteral:
Enabled: false
-# Offense count: 56
+# Offense count: 59
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Enabled: false
-# Offense count: 184
+# Offense count: 214
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
Enabled: false
-# Offense count: 8
+# Offense count: 9
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Enabled: false
-# Offense count: 268
+# Offense count: 285
# Configuration parameters: MinBodyLength.
Style/GuardClause:
Enabled: false
-# Offense count: 14
+# Offense count: 16
Style/IfInsideElse:
Enabled: false
-# Offense count: 179
+# Offense count: 186
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
Enabled: false
-# Offense count: 57
+# Offense count: 99
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
Enabled: false
-# Offense count: 120
+# Offense count: 160
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
Enabled: false
-# Offense count: 45
+# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
Enabled: false
-# Offense count: 7
+# Offense count: 6
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Enabled: false
-# Offense count: 22
+# Offense count: 34
# Cop supports --auto-correct.
Style/MethodCallWithoutArgsParentheses:
Enabled: false
-# Offense count: 9
+# Offense count: 10
Style/MethodMissing:
Enabled: false
@@ -169,26 +195,26 @@ Style/MethodMissing:
Style/MultilineIfModifier:
Enabled: false
-# Offense count: 22
+# Offense count: 24
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Enabled: false
-# Offense count: 17
+# Offense count: 18
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Enabled: false
-# Offense count: 31
+# Offense count: 37
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Enabled: false
-# Offense count: 77
+# Offense count: 88
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
# SupportedStyles: predicate, comparison
@@ -200,7 +226,7 @@ Style/NumericPredicate:
Style/ParallelAssignment:
Enabled: false
-# Offense count: 477
+# Offense count: 570
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
@@ -211,7 +237,7 @@ Style/PercentLiteralDelimiters:
Style/PerlBackrefs:
Enabled: false
-# Offense count: 72
+# Offense count: 83
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
@@ -219,21 +245,21 @@ Style/PerlBackrefs:
Style/PredicateName:
Enabled: false
-# Offense count: 39
+# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
Style/PreferredHashMethods:
Enabled: false
-# Offense count: 62
+# Offense count: 65
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
Enabled: false
-# Offense count: 4
+# Offense count: 5
# Cop supports --auto-correct.
Style/RedundantBegin:
Enabled: false
@@ -249,19 +275,19 @@ Style/RedundantFreeze:
Style/RedundantReturn:
Enabled: false
-# Offense count: 365
+# Offense count: 382
# Cop supports --auto-correct.
Style/RedundantSelf:
Enabled: false
-# Offense count: 108
+# Offense count: 111
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
Enabled: false
-# Offense count: 22
+# Offense count: 24
# Cop supports --auto-correct.
Style/RescueModifier:
Enabled: false
@@ -277,7 +303,7 @@ Style/SelfAssignment:
Style/SingleLineMethods:
Enabled: false
-# Offense count: 155
+# Offense count: 168
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
@@ -290,14 +316,14 @@ Style/SpaceBeforeBlockBraces:
Style/SpaceBeforeFirstArg:
Enabled: false
-# Offense count: 38
+# Offense count: 46
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
Enabled: false
-# Offense count: 203
+# Offense count: 229
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
@@ -305,58 +331,58 @@ Style/SpaceInLambdaLiteral:
Style/SpaceInsideBlockBraces:
Enabled: false
-# Offense count: 91
+# Offense count: 116
# Cop supports --auto-correct.
Style/SpaceInsideParens:
Enabled: false
-# Offense count: 4
+# Offense count: 12
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Enabled: false
-# Offense count: 55
+# Offense count: 57
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
EnforcedStyle: use_perl_names
-# Offense count: 40
+# Offense count: 42
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Enabled: false
-# Offense count: 57
+# Offense count: 64
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
Enabled: false
-# Offense count: 5
+# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
Style/TernaryParentheses:
Enabled: false
-# Offense count: 43
+# Offense count: 53
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
Enabled: false
-# Offense count: 13
+# Offense count: 18
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Enabled: false
-# Offense count: 70
+# Offense count: 78
# Cop supports --auto-correct.
Style/TrailingWhitespace:
Enabled: false
@@ -373,7 +399,7 @@ Style/TrivialAccessors:
Style/UnlessElse:
Enabled: false
-# Offense count: 22
+# Offense count: 24
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Enabled: false