diff options
| author | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-02-22 07:58:50 +0000 |
|---|---|---|
| committer | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-02-22 07:58:50 +0000 |
| commit | 2c1a1e56890e4da519a91a1e0aeda5037ce29fbf (patch) | |
| tree | 22d246e13f7acf2fa9ddea51a8b575be8125cfa2 | |
| parent | 86f451ccfa09e7d918b7c50b9a7a03598e85eed7 (diff) | |
| parent | aa1b7f2dc4c8995e20deba0e0e9ed60cf04fb1f7 (diff) | |
| download | gitlab-ce-2c1a1e56890e4da519a91a1e0aeda5037ce29fbf.tar.gz | |
Merge branch '43134-reduce-queries-pipelines-controller-show' into 'master'
Resolve "Controller Projects::PipelinesController#show executes more than 100 SQL queries"
Closes #43134
See merge request gitlab-org/gitlab-ce!17168
| -rw-r--r-- | app/models/ci/pipeline.rb | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index 2abe90dd181..a72a815bfe8 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -13,7 +13,7 @@ module Ci belongs_to :pipeline_schedule, class_name: 'Ci::PipelineSchedule' has_many :stages - has_many :statuses, class_name: 'CommitStatus', foreign_key: :commit_id + has_many :statuses, class_name: 'CommitStatus', foreign_key: :commit_id, inverse_of: :pipeline has_many :builds, foreign_key: :commit_id has_many :trigger_requests, dependent: :destroy, foreign_key: :commit_id # rubocop:disable Cop/ActiveRecordDependent has_many :variables, class_name: 'Ci::PipelineVariable' diff --git a/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml b/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml new file mode 100644 index 00000000000..c1e9614b676 --- /dev/null +++ b/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml @@ -0,0 +1,5 @@ +--- +title: Improve performance of pipeline page by reducing DB queries +merge_request: 17168 +author: +type: performance |