summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2018-04-18 18:33:47 +0000
committerRobert Speicher <robert@gitlab.com>2018-04-18 18:33:47 +0000
commit8815f0f70502e68532a7055db2de50699f63e65a (patch)
tree0ee99ccb76e943e6e9959a10099431ce48c4bad8
parent28891da395ecca9be0984180fe4c691c7854bfd1 (diff)
parent61250269ecdd93cc6dbd51979ac15b21cfa542ee (diff)
downloadgitlab-ce-8815f0f70502e68532a7055db2de50699f63e65a.tar.gz
Merge branch '10-7-stable-prepare-rc7' into '10-7-stable'
Prepare 10.7 RC7 release See merge request gitlab-org/gitlab-ce!18446
-rw-r--r--app/models/ci/build.rb2
-rw-r--r--spec/models/ci/build_spec.rb4
2 files changed, 1 insertions, 5 deletions
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index 4aa65bf4273..3e3ef674dff 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -162,7 +162,7 @@ module Ci
build.validates_dependencies! unless Feature.enabled?('ci_disable_validates_dependencies')
end
- before_transition pending: :running do |build|
+ after_transition pending: :running do |build|
build.ensure_metadata.update_timeout_state
end
end
diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb
index a12717835b0..d7075d4a6b4 100644
--- a/spec/models/ci/build_spec.rb
+++ b/spec/models/ci/build_spec.rb
@@ -2140,10 +2140,6 @@ describe Ci::Build do
it "doesn't save timeout_source" do
expect { run_job_without_exception }.not_to change { job.reload.ensure_metadata.timeout_source }
end
-
- it 'raises an exception' do
- expect { job.run! }.to raise_error(StateMachines::InvalidTransition)
- end
end
end