summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValery Sizov <valery@gitlab.com>2017-05-24 13:25:12 +0300
committerSean McGivern <sean@gitlab.com>2017-12-11 10:49:23 +0000
commit43442be4e594113913206c0739c031189ce5b70d (patch)
tree07d049ab20aa624d80d8ae413cbef4c7bb67aa83
parentb1aa91fbacda5987cfac7103308eb7bd0589b720 (diff)
downloadgitlab-ce-43442be4e594113913206c0739c031189ce5b70d.tar.gz
Fix specs after removing assignee_id field
-rw-r--r--db/migrate/20170523073948_remove_assignee_id_from_issue.rb2
-rw-r--r--features/steps/groups.rb2
-rw-r--r--spec/services/members/authorized_destroy_service_spec.rb2
3 files changed, 4 insertions, 2 deletions
diff --git a/db/migrate/20170523073948_remove_assignee_id_from_issue.rb b/db/migrate/20170523073948_remove_assignee_id_from_issue.rb
index e310a6df9bd..6fe2bb9c770 100644
--- a/db/migrate/20170523073948_remove_assignee_id_from_issue.rb
+++ b/db/migrate/20170523073948_remove_assignee_id_from_issue.rb
@@ -32,5 +32,7 @@ class RemoveAssigneeIdFromIssue < ActiveRecord::Migration
def down
add_column :issues, :assignee_id, :integer
add_concurrent_index :issues, :assignee_id
+
+ execute('UPDATE issues SET assignee_id = (SELECT user_id FROM issue_assignees WHERE issue_assignees.issue_id = issues.id LIMIT 1)')
end
end
diff --git a/features/steps/groups.rb b/features/steps/groups.rb
index a2d9a0332e0..753694a5392 100644
--- a/features/steps/groups.rb
+++ b/features/steps/groups.rb
@@ -138,7 +138,7 @@ class Spinach::Features::Groups < Spinach::FeatureSteps
private
def assigned_to_me(key)
- project.send(key).where(assignee_id: current_user.id)
+ project.send(key).assigned_to(current_user)
end
def project
diff --git a/spec/services/members/authorized_destroy_service_spec.rb b/spec/services/members/authorized_destroy_service_spec.rb
index 2d04d824180..d4ef31c0c74 100644
--- a/spec/services/members/authorized_destroy_service_spec.rb
+++ b/spec/services/members/authorized_destroy_service_spec.rb
@@ -45,7 +45,7 @@ describe Members::AuthorizedDestroyService do
expect { described_class.new(member, member_user).execute }
.to change { number_of_assigned_issuables(member_user) }.from(4).to(2)
- expect(issue.reload.assignee_id).to be_nil
+ expect(issue.reload.assignee_ids).to be_empty
expect(merge_request.reload.assignee_id).to be_nil
end
end