summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2018-05-08 17:47:24 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-05-09 10:01:59 +0100
commit7c3c068537d2186dba414f68a78e85fe34b36f78 (patch)
tree8fdba0b8cc4d0d52bb722801eacf98ea601d1fb3
parent84ea440042518659f95cb84a9f5254df93a24a01 (diff)
downloadgitlab-ce-7c3c068537d2186dba414f68a78e85fe34b36f78.tar.gz
Merge branch 'fix_plural_handling_for_migration_to_ghost_user' into 'master'
Cleanly handle plural name for ghost user migration See merge request gitlab-org/gitlab-ce!18798
-rw-r--r--app/services/users/migrate_to_ghost_user_service.rb4
-rw-r--r--spec/support/services/migrate_to_ghost_user_service_shared_examples.rb2
2 files changed, 3 insertions, 3 deletions
diff --git a/app/services/users/migrate_to_ghost_user_service.rb b/app/services/users/migrate_to_ghost_user_service.rb
index 976017dfa82..a2833b1e051 100644
--- a/app/services/users/migrate_to_ghost_user_service.rb
+++ b/app/services/users/migrate_to_ghost_user_service.rb
@@ -49,7 +49,7 @@ module Users
migrate_merge_requests
migrate_notes
migrate_abuse_reports
- migrate_award_emojis
+ migrate_award_emoji
end
def migrate_issues
@@ -70,7 +70,7 @@ module Users
user.reported_abuse_reports.update_all(reporter_id: ghost_user.id)
end
- def migrate_award_emojis
+ def migrate_award_emoji
user.award_emoji.update_all(user_id: ghost_user.id)
end
end
diff --git a/spec/support/services/migrate_to_ghost_user_service_shared_examples.rb b/spec/support/services/migrate_to_ghost_user_service_shared_examples.rb
index adfd256dff1..1478c6b5a47 100644
--- a/spec/support/services/migrate_to_ghost_user_service_shared_examples.rb
+++ b/spec/support/services/migrate_to_ghost_user_service_shared_examples.rb
@@ -86,7 +86,7 @@ shared_examples "migrating a deleted user's associated records to the ghost user
end
it "blocks the user before #{record_class_name} migration begins" do
- expect(service).to receive("migrate_#{record_class_name.parameterize('_')}s".to_sym) do
+ expect(service).to receive("migrate_#{record_class_name.parameterize('_').pluralize}".to_sym) do
expect(user.reload).to be_blocked
end