diff options
author | Fatih Acet <acetfatih@gmail.com> | 2019-06-05 15:20:11 +0000 |
---|---|---|
committer | GitLab Release Tools Bot <robert+release-tools@gitlab.com> | 2019-06-10 07:15:29 +0000 |
commit | cfac448bb592afd3fc21954a84e9debefa4cc9a8 (patch) | |
tree | b0e7f5d2b5ed1fc68e6423d63568191dc44b398a | |
parent | f8c953861df7df971c670585991d2f394f1650f8 (diff) | |
download | gitlab-ce-cfac448bb592afd3fc21954a84e9debefa4cc9a8.tar.gz |
Merge branch '61246-fix-label-click-scroll-to-top' into 'master'
Fix label click scrolling to top
Closes #61246
See merge request gitlab-org/gitlab-ce!29202
(cherry picked from commit 92b06c13bd12abf85f6beb18b3b5c2f0e38c2760)
c9c7fa7b Fix label click scrolling to top
-rw-r--r-- | app/assets/javascripts/gl_dropdown.js | 5 | ||||
-rw-r--r-- | changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/app/assets/javascripts/gl_dropdown.js b/app/assets/javascripts/gl_dropdown.js index 1c6b18c0e03..e52bc8583c6 100644 --- a/app/assets/javascripts/gl_dropdown.js +++ b/app/assets/javascripts/gl_dropdown.js @@ -561,6 +561,11 @@ GitLabDropdown = (function() { !$target.data('isLink') ) { e.stopPropagation(); + + // This prevents automatic scrolling to the top + if ($target.is('a')) { + return false; + } } return true; diff --git a/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml b/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml new file mode 100644 index 00000000000..7fa15e1c0fd --- /dev/null +++ b/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml @@ -0,0 +1,5 @@ +--- +title: Fix label click scrolling to top +merge_request: 29202 +author: +type: fixed |