diff options
| author | Jacopo <beschi.jacopo@gmail.com> | 2018-08-28 16:02:48 +0200 |
|---|---|---|
| committer | Jacopo <beschi.jacopo@gmail.com> | 2018-08-29 16:56:34 +0200 |
| commit | 4a37cd0dc08ccef417a423b3a9a91b33c26c4199 (patch) | |
| tree | c1e18140d24742d367cee77a6785608f460f4ada | |
| parent | e3e746623b2fa6c45dab66dd1618810a53cdecd8 (diff) | |
| download | gitlab-ce-4a37cd0dc08ccef417a423b3a9a91b33c26c4199.tar.gz | |
Minor renames for clarity
| -rw-r--r-- | rubocop/cop/prefer_class_methods_over_module.rb | 4 | ||||
| -rw-r--r-- | spec/rubocop/cop/prefer_class_methods_over_module_spec.rb | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/rubocop/cop/prefer_class_methods_over_module.rb b/rubocop/cop/prefer_class_methods_over_module.rb index 5097dc7829d..0dfa80ccfab 100644 --- a/rubocop/cop/prefer_class_methods_over_module.rb +++ b/rubocop/cop/prefer_class_methods_over_module.rb @@ -36,7 +36,7 @@ module RuboCop PATTERN def on_module(node) - add_offense(node) if node.defined_module_name == 'ClassMethods' && extends_activesupport_concern?(node) + add_offense(node) if node.defined_module_name == 'ClassMethods' && module_extends_activesupport_concern?(node) end def autocorrect(node) @@ -47,7 +47,7 @@ module RuboCop private - def extends_activesupport_concern?(node) + def module_extends_activesupport_concern?(node) container_module = container_module_of(node) return false unless container_module diff --git a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb index ec60a651f31..4739f0e6c47 100644 --- a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb +++ b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb @@ -93,6 +93,6 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do end end RUBY - expect(autocorrected).to eql(expected_source) + expect(autocorrected).to eq(expected_source) end end |