diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-01 11:18:11 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-01 11:18:11 +0200 |
commit | 0319d5b63233e132672b836409b8a073cab05d10 (patch) | |
tree | 89f487a2c6f205fc3f426ebc643abe9e39b07a9b | |
parent | 473ea1e974cf07751601904b882de9ee2b3d0618 (diff) | |
download | gitlab-ce-0319d5b63233e132672b836409b8a073cab05d10.tar.gz |
Enable Style/For rubocop coprubocop/enable-style-for-cop
Do not use for, unless you know exactly why.
See #17478
-rw-r--r-- | .rubocop.yml | 2 | ||||
-rw-r--r-- | app/models/network/graph.rb | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index eece9ec69d8..21ac2749437 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -247,7 +247,7 @@ Style/FlipFlop: # Checks use of for or each in multiline loops. Style/For: - Enabled: false + Enabled: true # Enforce the use of Kernel#sprintf, Kernel#format or String#%. Style/FormatString: diff --git a/app/models/network/graph.rb b/app/models/network/graph.rb index 1ac37e0307f..7f3387f87e2 100644 --- a/app/models/network/graph.rb +++ b/app/models/network/graph.rb @@ -205,7 +205,7 @@ module Network # Visit branching chains leaves.each do |l| parents = l.parents(@map).select{|p| p.space.zero?} - for p in parents + parents.each do |p| place_chain(p, l.time) end end @@ -223,7 +223,7 @@ module Network end def mark_reserved(time_range, space) - for day in time_range + time_range.each do |day| @reserved[day].push(space) end end @@ -232,7 +232,7 @@ module Network space_default ||= space_base reserved = [] - for day in time_range + time_range.each do |day| reserved.push(*@reserved[day]) end reserved.uniq! |