diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2014-03-24 09:48:17 +0200 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2014-03-24 09:48:17 +0200 |
| commit | 2db4d8f844d36a741c47d7d978f701c953d235ec (patch) | |
| tree | 69e50b5b0c6e38b5dea9cef1bc41fff8ca67e36f | |
| parent | 28eb6c69762e664c6c699a91b97a941f80fb002a (diff) | |
| parent | 6adbfda2f832b7e0e5a16718d625a3be3f137819 (diff) | |
| download | gitlab-ce-2db4d8f844d36a741c47d7d978f701c953d235ec.tar.gz | |
Merge pull request #6593 from jvanbaarsen/mr-template
Added some extra information how a good MR looks like
| -rw-r--r-- | CONTRIBUTING.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a6d6ec28ed9..d816f8e72a0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -77,6 +77,14 @@ Please keep the change in a single MR **as small as possible**. If you want to c For examples of feedback on merge requests please look at already [closed merge requests](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests?assignee_id=&label_name=&milestone_id=&scope=&sort=&state=closed). Please ensure that your merge request meets the following contribution acceptance criteria. +**Please format your merge request description as follows:** + +1. What does this MR do? +2. Are there points in the code the reviewer needs to double check? +3. Why was this MR needed? +4. What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)? +5. Screenshots (If appropiate) + ## Contribution acceptance criteria 1. The change is as small as possible (see the above paragraph for details) |