diff options
| author | Imre Farkas <ifarkas@gitlab.com> | 2019-11-26 09:32:07 +0100 |
|---|---|---|
| committer | Imre Farkas <ifarkas@gitlab.com> | 2019-11-26 12:13:00 +0100 |
| commit | 7aea2c20ce66f212874faa87abc67e0294e66f83 (patch) | |
| tree | bdcefeb082c0da1c69cd88e1929752fdbb43b0b0 | |
| parent | 483d36b2edc08062882eb111e697216c0cb234b5 (diff) | |
| download | gitlab-ce-7aea2c20ce66f212874faa87abc67e0294e66f83.tar.gz | |
Spec to ensure `_ids` are cleaned by ImportExport::AttributeCleaner
| -rw-r--r-- | changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml | 5 | ||||
| -rw-r--r-- | spec/lib/gitlab/import_export/attribute_cleaner_spec.rb | 5 |
2 files changed, 9 insertions, 1 deletions
diff --git a/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml b/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml new file mode 100644 index 00000000000..08fc1393f20 --- /dev/null +++ b/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml @@ -0,0 +1,5 @@ +--- +title: Ensure are cleaned by ImportExport::AttributeCleaner +merge_request: +author: +type: security diff --git a/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb b/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb index 873728f9909..1b28e26a7e8 100644 --- a/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb +++ b/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb @@ -24,7 +24,10 @@ describe Gitlab::ImportExport::AttributeCleaner do '_html' => '<p>perfectly ordinary html</p>', 'cached_markdown_version' => 12345, 'group_id' => 99, - 'commit_id' => 99 + 'commit_id' => 99, + 'issue_ids' => [1, 2, 3], + 'merge_request_ids' => [1, 2, 3], + 'note_ids' => [1, 2, 3] } end |