diff options
author | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-11-01 11:58:11 -0600 |
---|---|---|
committer | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-11-01 12:29:57 -0600 |
commit | 0c49b5eb17a35a3b1929e5dc6decf9a1cc7bd910 (patch) | |
tree | 737bc824943e9ab57d08b4d0e3c751926c3b87d7 | |
parent | 0b8b631ad9e914918e51bdb08ad56cd85c333847 (diff) | |
download | gitlab-ce-0c49b5eb17a35a3b1929e5dc6decf9a1cc7bd910.tar.gz |
Fix cancel button not working when uploading a file on the new issue pagejivl-fix-cancel-button-file-upload-new-issue
-rw-r--r-- | app/assets/javascripts/dropzone_input.js | 4 | ||||
-rw-r--r-- | changelogs/unreleased/jivl-fix-cancel-button-file-upload-new-issue.yml | 5 | ||||
-rw-r--r-- | spec/features/issues_spec.rb | 10 |
3 files changed, 16 insertions, 3 deletions
diff --git a/app/assets/javascripts/dropzone_input.js b/app/assets/javascripts/dropzone_input.js index 7a17adcd44e..b7747ee3f83 100644 --- a/app/assets/javascripts/dropzone_input.js +++ b/app/assets/javascripts/dropzone_input.js @@ -119,11 +119,9 @@ export default function dropzoneInput(form) { // removeAllFiles(true) stops uploading files (if any) // and remove them from dropzone files queue. $cancelButton.on('click', (e) => { - const target = e.target.closest('.js-main-target-form').querySelector('.div-dropzone'); - e.preventDefault(); e.stopPropagation(); - Dropzone.forElement(target).removeAllFiles(true); + Dropzone.forElement($formDropzone.get(0)).removeAllFiles(true); }); // If 'error' event is fired, we store a failed files, diff --git a/changelogs/unreleased/jivl-fix-cancel-button-file-upload-new-issue.yml b/changelogs/unreleased/jivl-fix-cancel-button-file-upload-new-issue.yml new file mode 100644 index 00000000000..0205d9626b1 --- /dev/null +++ b/changelogs/unreleased/jivl-fix-cancel-button-file-upload-new-issue.yml @@ -0,0 +1,5 @@ +--- +title: Fix cancel button not working while uploading on the new issue page +merge_request: 15137 +author: +type: fixed diff --git a/spec/features/issues_spec.rb b/spec/features/issues_spec.rb index d4fd3a50008..9b94452fb0d 100644 --- a/spec/features/issues_spec.rb +++ b/spec/features/issues_spec.rb @@ -583,6 +583,16 @@ describe 'Issues' do expect(page.find_field("issue_description").value).not_to match /\n\n$/ end + + it "cancels a file upload correctly" do + dropzone_file([Rails.root.join('spec', 'fixtures', 'dk.png')], 0, false) + + click_button 'Cancel' + + expect(page).to have_button('Attach a file') + expect(page).not_to have_button('Cancel') + expect(page).not_to have_selector('.uploading-progress-container', visible: true) + end end context 'form filled by URL parameters' do |