summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-04-24 10:12:59 +0100
committerFilipa Lacerda <filipa@gitlab.com>2018-04-24 10:15:37 +0100
commit09a9fcc9b0e36a8276c53127bbe171d6ff336ad0 (patch)
treeced7d7022813dd46b70fc7171d67b8a54eb2c84d
parent2c3065c1601c31864c5d4b74d637473aa5973168 (diff)
downloadgitlab-ce-09a9fcc9b0e36a8276c53127bbe171d6ff336ad0.tar.gz
Updates CSS for non a tags inside dropdown
-rw-r--r--app/assets/javascripts/pipelines/components/graph/job_component.vue2
-rw-r--r--app/assets/javascripts/pipelines/components/stage.vue6
-rw-r--r--app/assets/javascripts/pipelines/pipeline_details_bundle.js1
-rw-r--r--app/assets/stylesheets/pages/pipelines.scss5
4 files changed, 9 insertions, 5 deletions
diff --git a/app/assets/javascripts/pipelines/components/graph/job_component.vue b/app/assets/javascripts/pipelines/components/graph/job_component.vue
index 4fcd4b79f4a..c1f0f051b63 100644
--- a/app/assets/javascripts/pipelines/components/graph/job_component.vue
+++ b/app/assets/javascripts/pipelines/components/graph/job_component.vue
@@ -108,7 +108,7 @@ export default {
<div
v-else
v-tooltip
- class="js-job-component-tooltip"
+ class="js-job-component-tooltip non-details-job-component"
:title="tooltipText"
:class="cssClassJobName"
data-html="true"
diff --git a/app/assets/javascripts/pipelines/components/stage.vue b/app/assets/javascripts/pipelines/components/stage.vue
index 5a74dfed0ff..0b7130517d3 100644
--- a/app/assets/javascripts/pipelines/components/stage.vue
+++ b/app/assets/javascripts/pipelines/components/stage.vue
@@ -96,7 +96,7 @@ export default {
axios
.get(this.stage.dropdown_path)
.then(({ data }) => {
- this.dropdownContent = data;
+ this.dropdownContent = data.latest_statuses;
this.isLoading = false;
})
.catch(() => {
@@ -117,7 +117,7 @@ export default {
*/
stopDropdownClickPropagation() {
$(
- this.$el.querySelectorAll('.js-builds-dropdown-list a.mini-pipeline-graph-dropdown-item')
+ this.$el.querySelectorAll('.js-builds-dropdown-list a.mini-pipeline-graph-dropdown-item'),
).on('click', e => {
e.stopPropagation();
});
@@ -183,7 +183,7 @@ export default {
<li
v-for="job in dropdownContent"
:key="job.id"
- >
+ >
<job-component
:job="job"
css-class-job-name="mini-pipeline-graph-dropdown-item"
diff --git a/app/assets/javascripts/pipelines/pipeline_details_bundle.js b/app/assets/javascripts/pipelines/pipeline_details_bundle.js
index b743364ff43..6584f96130b 100644
--- a/app/assets/javascripts/pipelines/pipeline_details_bundle.js
+++ b/app/assets/javascripts/pipelines/pipeline_details_bundle.js
@@ -48,7 +48,6 @@ export default () => {
.catch(() => {
this.requestFinishedFor = action;
Flash(__('An error occurred while making the request.'));
- eventHub.$emit('graphActionFinished', action);
});
},
},
diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss
index ab75e0fe51e..c538dad81b0 100644
--- a/app/assets/stylesheets/pages/pipelines.scss
+++ b/app/assets/stylesheets/pages/pipelines.scss
@@ -805,6 +805,11 @@ button.mini-pipeline-graph-dropdown-toggle {
line-height: $line-height-base;
white-space: nowrap;
+ // Match dropdown.scss for all `a` tags
+ &.non-details-job-component {
+ padding: 8px 16px;
+ }
+
.ci-job-name-component {
align-items: center;
display: flex;