summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-05-14 18:30:23 +0300
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-05-14 18:30:23 +0300
commit3d4d89f060f01b7993ef8e1839744c81b53293bf (patch)
tree807cf443e3184dd844924a06bee6e5f827377c31
parent8dde52cc099af63e1bdc02ca6fc389e4a9ea9969 (diff)
downloadgitlab-ce-3d4d89f060f01b7993ef8e1839744c81b53293bf.tar.gz
Use count badges with number_with_delimiter helper for issue, commit count
-rw-r--r--app/helpers/application_helper.rb17
-rw-r--r--app/views/projects/commits/_head.html.haml2
2 files changed, 14 insertions, 5 deletions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 672be54e66f..26bb3c66fd6 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -324,12 +324,21 @@ module ApplicationHelper
count =
if project.nil?
- ""
+ nil
elsif current_controller?(:issues)
- " (#{project.issues.send(entity).count})"
+ project.issues.send(entity).count
elsif current_controller?(:merge_requests)
- " (#{project.merge_requests.send(entity).count})"
+ project.merge_requests.send(entity).count
end
- "#{entity_title}#{count}"
+
+ html = ""
+ html += content_tag :span, entity_title
+ html += "&nbsp;"
+
+ if count.present?
+ html += content_tag :span, number_with_delimiter(count), class: 'badge'
+ end
+
+ html.html_safe
end
end
diff --git a/app/views/projects/commits/_head.html.haml b/app/views/projects/commits/_head.html.haml
index 66261c7336d..e3d8cd0fdd5 100644
--- a/app/views/projects/commits/_head.html.haml
+++ b/app/views/projects/commits/_head.html.haml
@@ -3,7 +3,7 @@
= link_to namespace_project_commits_path(@project.namespace, @project, @ref || @repository.root_ref) do
= icon("history")
Commits
- %span.badge= number_with_precision(@repository.commit_count, precision: 0, delimiter: ',')
+ %span.badge= number_with_delimiter(@repository.commit_count)
= nav_link(controller: :compare) do
= link_to namespace_project_compare_index_path(@project.namespace, @project, from: @repository.root_ref, to: @ref || @repository.root_ref) do
= icon("exchange")