diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2016-08-19 14:10:20 +0000 |
---|---|---|
committer | Ruben Davila <rdavila84@gmail.com> | 2016-09-20 11:53:50 -0500 |
commit | 5c159b0dea3ea31d408d0ec6eb3dd26ff7743d5a (patch) | |
tree | fa1760fc090225d836876b1f6ef688a5fd6caa33 | |
parent | f22203919d1342d75af3c26c71ed7d84224617c8 (diff) | |
download | gitlab-ce-5c159b0dea3ea31d408d0ec6eb3dd26ff7743d5a.tar.gz |
Merge branch 'fix-branch-title-trailing-space' into 'master'
Fix branch title trailing space on hover
## What does this MR do?
Removes the unnecessary encapsulation of the `<span>` inside of the `<a>` which was creating the trailing space on hover.
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
Makes the UI look more polished
## What are the relevant issue numbers?
Closes #20676
## Screenshots (if relevant)
Before (When hovering on branch title):
![Screen_Shot_2016-08-05_at_2.54.43_PM](/uploads/1c90ae1ed69268a2fdcdafdede267028/Screen_Shot_2016-08-05_at_2.54.43_PM.png)
After (When hovering on branch title):
![Screen_Shot_2016-08-05_at_2.54.19_PM](/uploads/6eab261a343e7acb6223ed205443b644/Screen_Shot_2016-08-05_at_2.54.19_PM.png)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5688
-rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 936e27270e6..088f9ee44f1 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -293,6 +293,7 @@ v 8.11.0 - Enforce 2FA restrictions on API authentication endpoints !5820 - Limit git rev-list output count to one in forced push check - Show deployment status on merge requests with external URLs + - Fix branch title trailing space on hover (ClemMakesApps) - Clean up unused routes (Josef Strzibny) - Fix issue on empty project to allow developers to only push to protected branches if given permission - API: Add enpoints for pipelines |