summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2016-12-23 20:32:32 +0000
committerMarin Jankovski <marin@gitlab.com>2016-12-27 16:55:29 +0000
commit81cb58c2fb22ec7030cd83ca5443e22530707364 (patch)
tree34617d67391421d1ffcbf36a925e53182e279570
parent642669cc85bba4d3cdbabbe3ddf90cb60114cb88 (diff)
downloadgitlab-ce-81cb58c2fb22ec7030cd83ca5443e22530707364.tar.gz
Merge branch '25930-discussion-actions-overlap-header-text' into 'master'
Fix text overflow Closes #25930 See merge request !8273
-rw-r--r--app/assets/stylesheets/pages/notes.scss29
-rw-r--r--app/views/projects/notes/_note.html.haml2
-rw-r--r--changelogs/unreleased/25930-discussion-actions-overlap-header-text.yml4
3 files changed, 23 insertions, 12 deletions
diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss
index c3edf8a65b5..8f15775ee03 100644
--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -43,7 +43,7 @@ ul.notes {
}
.system-note-message {
- display: inline;
+ display: inline-block;
&::first-letter {
text-transform: lowercase;
@@ -55,7 +55,7 @@ ul.notes {
}
p {
- display: inline;
+ display: inline-block;
margin: 0;
&::first-letter {
@@ -151,10 +151,6 @@ ul.notes {
}
}
}
-
- .note-headline-light {
- display: inline;
- }
}
.discussion-body {
@@ -452,11 +448,6 @@ ul.notes {
border-radius: $border-radius-base;
}
-.diff-file .note .note-actions {
- right: 0;
- top: 0;
-}
-
/**
* Line note button on the side of diffs
@@ -586,3 +577,19 @@ ul.notes {
}
}
}
+
+// Merge request notes in diffs
+.diff-file {
+
+ // Diff is side by side
+ .notes_content.parallel .note-header .note-headline-light {
+ display: block;
+ position: relative;
+ }
+
+ // Diff is inline
+ .notes_content .note-header .note-headline-light {
+ display: inline-block;
+ position: relative;
+ }
+}
diff --git a/app/views/projects/notes/_note.html.haml b/app/views/projects/notes/_note.html.haml
index 778a32e6345..399cf85cd0f 100644
--- a/app/views/projects/notes/_note.html.haml
+++ b/app/views/projects/notes/_note.html.haml
@@ -10,7 +10,7 @@
.timeline-content
.note-header
= link_to_member(note.project, note.author, avatar: false)
- .inline.note-headline-light
+ .note-headline-light
= note.author.to_reference
- unless note.system
commented
diff --git a/changelogs/unreleased/25930-discussion-actions-overlap-header-text.yml b/changelogs/unreleased/25930-discussion-actions-overlap-header-text.yml
new file mode 100644
index 00000000000..54a461c24ed
--- /dev/null
+++ b/changelogs/unreleased/25930-discussion-actions-overlap-header-text.yml
@@ -0,0 +1,4 @@
+---
+title: Fix discussion overlap text in regular screens
+merge_request: 8273
+author: