summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2017-02-23 22:39:48 +0000
committerRuben Davila <rdavila84@gmail.com>2017-02-27 23:46:48 -0500
commit4269d6bccd44084267a4565f18be5e6499a62a13 (patch)
tree8cf8431138029e2ac57a76fce1e5742e584624dc
parentfbf3fea6a49bdf9ded497649a50dd75aa70fb712 (diff)
downloadgitlab-ce-4269d6bccd44084267a4565f18be5e6499a62a13.tar.gz
Merge branch '27989-disable-counting-tags' into 'master'
Disable unused tags count cache for Projects, Builds and Runners Closes #27989 See merge request !9467
-rw-r--r--app/models/issue.rb2
-rw-r--r--app/models/project.rb3
-rw-r--r--changelogs/unreleased/27989-disable-counting-tags.yml4
-rw-r--r--config/initializers/acts_as_taggable.rb5
4 files changed, 10 insertions, 4 deletions
diff --git a/app/models/issue.rb b/app/models/issue.rb
index d8826b65fcc..de90f19f854 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -15,8 +15,6 @@ class Issue < ActiveRecord::Base
DueThisWeek = DueDateStruct.new('Due This Week', 'week').freeze
DueThisMonth = DueDateStruct.new('Due This Month', 'month').freeze
- ActsAsTaggableOn.strict_case_match = true
-
belongs_to :project
belongs_to :moved_to, class_name: 'Issue'
diff --git a/app/models/project.rb b/app/models/project.rb
index b45f22d94d9..4a3e18f07d3 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -70,8 +70,7 @@ class Project < ActiveRecord::Base
after_validation :check_pending_delete
- ActsAsTaggableOn.strict_case_match = true
- acts_as_taggable_on :tags
+ acts_as_taggable
attr_accessor :new_default_branch
attr_accessor :old_path_with_namespace
diff --git a/changelogs/unreleased/27989-disable-counting-tags.yml b/changelogs/unreleased/27989-disable-counting-tags.yml
new file mode 100644
index 00000000000..988785ac454
--- /dev/null
+++ b/changelogs/unreleased/27989-disable-counting-tags.yml
@@ -0,0 +1,4 @@
+---
+title: Disable unused tags count cache for Projects, Builds and Runners
+merge_request:
+author:
diff --git a/config/initializers/acts_as_taggable.rb b/config/initializers/acts_as_taggable.rb
new file mode 100644
index 00000000000..c564c0cab11
--- /dev/null
+++ b/config/initializers/acts_as_taggable.rb
@@ -0,0 +1,5 @@
+ActsAsTaggableOn.strict_case_match = true
+
+# tags_counter enables caching count of tags which results in an update whenever a tag is added or removed
+# since the count is not used anywhere its better performance wise to disable this cache
+ActsAsTaggableOn.tags_counter = false