diff options
author | Douwe Maan <douwe@gitlab.com> | 2016-01-25 09:35:54 +0000 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2016-01-26 11:48:14 -0800 |
commit | 40b670f12a6b34596282ae01854809b1bbb5d2b4 (patch) | |
tree | e713cd01074b225760a4fb31b6082bb7dbb986f9 | |
parent | c522d2ff655d6494cb45fcf9983d87abadbd655a (diff) | |
download | gitlab-ce-40b670f12a6b34596282ae01854809b1bbb5d2b4.tar.gz |
Merge branch 'update-gitlab-git' into 'master'
Update gitlab_git & use new method for counting branches
Corresponding gitlab_git merge request detailing some of the rationale behind this: https://gitlab.com/gitlab-org/gitlab_git/merge_requests/62
Fixes #12418
See merge request !2535
-rw-r--r-- | Gemfile.lock | 2 | ||||
-rw-r--r-- | app/models/repository.rb | 2 | ||||
-rw-r--r-- | spec/models/repository_spec.rb | 20 |
3 files changed, 22 insertions, 2 deletions
diff --git a/Gemfile.lock b/Gemfile.lock index 1386e2c45f2..14d2c76bc3b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -356,7 +356,7 @@ GEM posix-spawn (~> 0.3) gitlab_emoji (0.2.0) gemojione (~> 2.1) - gitlab_git (7.2.22) + gitlab_git (7.2.24) activesupport (~> 4.0) charlock_holmes (~> 0.7.3) github-linguist (~> 4.7.0) diff --git a/app/models/repository.rb b/app/models/repository.rb index d9ff71c01ed..f89a3890a49 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -57,7 +57,7 @@ class Repository # This method return true if repository contains some content visible in project page. # def has_visible_content? - !raw_repository.branches.empty? + raw_repository.branch_count > 0 end def commit(id = 'HEAD') diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb index afbf62035ac..c484ae8fc8c 100644 --- a/spec/models/repository_spec.rb +++ b/spec/models/repository_spec.rb @@ -219,4 +219,24 @@ describe Repository, models: true do end end end + + describe '#has_visible_content?' do + subject { repository.has_visible_content? } + + describe 'when there are no branches' do + before do + allow(repository.raw_repository).to receive(:branch_count).and_return(0) + end + + it { is_expected.to eq(false) } + end + + describe 'when there are branches' do + before do + allow(repository.raw_repository).to receive(:branch_count).and_return(3) + end + + it { is_expected.to eq(true) } + end + end end |