diff options
| author | Jacob Schatz <jschatz1@gmail.com> | 2016-03-22 20:33:07 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-03-23 12:27:33 +0100 |
| commit | 5a20d3ab51ebe6b64adfa1fcfab03a26734ba0bb (patch) | |
| tree | 9224233a5bd4536c11728a0e94b762455c5ab9cf | |
| parent | 3536b17e97ca71576644db9ac59bcbb2eeb3de4b (diff) | |
| download | gitlab-ce-5a20d3ab51ebe6b64adfa1fcfab03a26734ba0bb.tar.gz | |
Merge branch 'header-mobile-overflow' into 'master'
Fixes issue with signin button overflowing on mobile
Closes #14477
See merge request !3342
| -rw-r--r-- | CHANGELOG | 1 | ||||
| -rw-r--r-- | app/assets/stylesheets/framework/common.scss | 5 | ||||
| -rw-r--r-- | app/assets/stylesheets/framework/header.scss | 5 | ||||
| -rw-r--r-- | app/views/layouts/header/_default.html.haml | 7 |
4 files changed, 14 insertions, 4 deletions
diff --git a/CHANGELOG b/CHANGELOG index 5a7de741369..502cc687b28 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -3,6 +3,7 @@ Please view this file on the master branch, on stable branches it's out of date. v 8.6.1 (unreleased) - Add option to reload the schema before restoring a database backup. !2807 - Restrict notifications for confidential issues. !3334 + - Fixes issue with signin button overflowing on mobile. !3342 v 8.6.0 - Add ability to move issue to another project diff --git a/app/assets/stylesheets/framework/common.scss b/app/assets/stylesheets/framework/common.scss index bc03c2180be..1f770876464 100644 --- a/app/assets/stylesheets/framework/common.scss +++ b/app/assets/stylesheets/framework/common.scss @@ -292,8 +292,11 @@ table { } .btn-sign-in { - margin-top: 10px; text-shadow: none; + + @media (min-width: $screen-sm-min) { + margin-top: 11px; + } } .side-filters { diff --git a/app/assets/stylesheets/framework/header.scss b/app/assets/stylesheets/framework/header.scss index 71a7ecab8ef..6a68bb5c115 100644 --- a/app/assets/stylesheets/framework/header.scss +++ b/app/assets/stylesheets/framework/header.scss @@ -70,6 +70,11 @@ header { .header-content { height: $header-height; + padding-right: 20px; + + @media (min-width: $screen-sm-min) { + padding-right: 0; + } .title { margin: 0; diff --git a/app/views/layouts/header/_default.html.haml b/app/views/layouts/header/_default.html.haml index bfa5937cf3f..0f3b8119379 100644 --- a/app/views/layouts/header/_default.html.haml +++ b/app/views/layouts/header/_default.html.haml @@ -6,7 +6,7 @@ = icon('bars') .navbar-collapse.collapse - %ul.nav.navbar-nav.pull-right + %ul.nav.navbar-nav %li.hidden-sm.hidden-xs = render 'layouts/search' %li.visible-sm.visible-xs @@ -38,8 +38,9 @@ = link_to destroy_user_session_path, class: 'logout', method: :delete, title: 'Sign out', data: {toggle: 'tooltip', placement: 'bottom', container: 'body'} do = icon('sign-out') - else - .pull-right - = link_to "Sign in", new_session_path(:user, redirect_to_referer: 'yes'), class: 'btn btn-sign-in btn-success' + %li + %div + = link_to "Sign in", new_session_path(:user, redirect_to_referer: 'yes'), class: 'btn btn-sign-in btn-success' %h1.title= title |