diff options
author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-05-11 12:30:30 +0200 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-05-11 12:30:45 +0200 |
commit | 8ec1dcf247434e46cac878a18f82cc9d7c43c0c9 (patch) | |
tree | 3d87547c8a35ea4353c79e9b49dcf226f6f6a7e0 | |
parent | 0dc34317f6b8e53a8a06f179c8aaf856f3b030b5 (diff) | |
download | gitlab-ce-8ec1dcf247434e46cac878a18f82cc9d7c43c0c9.tar.gz |
Revert "Merge branch 'fix-build-notification-on-merge-page-change' into 'master'
"
This reverts commit d1ba09869542fa4d2198c6199cf820bc75fcbb63.
-rw-r--r-- | CHANGELOG | 1 | ||||
-rw-r--r-- | app/assets/javascripts/merge_request_widget.js.coffee | 9 | ||||
-rw-r--r-- | app/views/projects/merge_requests/widget/_heading.html.haml | 7 | ||||
-rw-r--r-- | spec/javascripts/merge_request_widget_spec.js.coffee | 6 |
4 files changed, 11 insertions, 12 deletions
diff --git a/CHANGELOG b/CHANGELOG index f865d6219fc..db341fe918c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -9,6 +9,7 @@ v 8.7.4 - Running rake gitlab:db:drop_tables now drops tables with cascade !4020 - Running rake gitlab:db:drop_tables uses "IF EXISTS" as a precaution !4100 - Use a case-insensitive comparison in sanitizing URI schemes + - Links for Redmine issue references are generated correctly again (Benedikt Huss) v 8.7.3 - Emails, Gitlab::Email::Message, Gitlab::Diff, and Premailer::Adapter::Nokogiri are now instrumented diff --git a/app/assets/javascripts/merge_request_widget.js.coffee b/app/assets/javascripts/merge_request_widget.js.coffee index f58647988a2..17a5a057a94 100644 --- a/app/assets/javascripts/merge_request_widget.js.coffee +++ b/app/assets/javascripts/merge_request_widget.js.coffee @@ -9,12 +9,11 @@ class @MergeRequestWidget constructor: (@opts) -> $('#modal_merge_info').modal(show: false) @firstCICheck = true - @readyForCICheck = false + @readyForCICheck = true clearInterval @fetchBuildStatusInterval @clearEventListeners() @addEventListeners() - @getCIStatus(false) @pollCIStatus() notifyPermissions() @@ -72,7 +71,7 @@ class @MergeRequestWidget if data.status is '' return - if @firstCICheck || data.status isnt @opts.ci_status and data.status? + if @firstCiCheck || data.status isnt @opts.ci_status and data.status? @opts.ci_status = data.status @showCIStatus data.status if data.coverage @@ -80,7 +79,7 @@ class @MergeRequestWidget # The first check should only update the UI, a notification # should only be displayed on status changes - if showNotification and not @firstCICheck + if showNotification and not @firstCiCheck status = @ciLabelForStatus(data.status) if status is "preparing" @@ -103,7 +102,7 @@ class @MergeRequestWidget @close() Turbolinks.visit _this.opts.builds_path ) - @firstCICheck = false + @firstCiCheck = false showCIStatus: (state) -> $('.ci_widget').hide() diff --git a/app/views/projects/merge_requests/widget/_heading.html.haml b/app/views/projects/merge_requests/widget/_heading.html.haml index 4d381754610..2ec0d20a879 100644 --- a/app/views/projects/merge_requests/widget/_heading.html.haml +++ b/app/views/projects/merge_requests/widget/_heading.html.haml @@ -41,4 +41,9 @@ .ci_widget.ci-error{style: "display:none"} = icon("times-circle") - Could not connect to the CI server. Please check your settings and try again.
\ No newline at end of file + Could not connect to the CI server. Please check your settings and try again. + + :javascript + $(function() { + merge_request_widget.getCIStatus(false); + }); diff --git a/spec/javascripts/merge_request_widget_spec.js.coffee b/spec/javascripts/merge_request_widget_spec.js.coffee index 92b7eeb1116..c0bd8a29e43 100644 --- a/spec/javascripts/merge_request_widget_spec.js.coffee +++ b/spec/javascripts/merge_request_widget_spec.js.coffee @@ -47,9 +47,3 @@ describe 'MergeRequestWidget', -> spy = spyOn(@class, 'showCICoverage').and.stub() @class.getCIStatus(false) expect(spy).not.toHaveBeenCalled() - - it 'should not display a notification on the first check after the widget has been created', -> - spy = spyOn(window, 'notify') - @class = new MergeRequestWidget(@opts) - @class.getCIStatus(true) - expect(spy).not.toHaveBeenCalled() |