diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2017-03-21 13:25:13 +0000 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2017-03-21 22:38:03 +0800 |
commit | 169c70fda4635d13fc69f86a6f20d07f755651e8 (patch) | |
tree | 944e4146aebce4eace182940804aae910997c8a9 | |
parent | afa4bd1bcf7b37403514e62c6e1bf0c89bac8db9 (diff) | |
download | gitlab-ce-169c70fda4635d13fc69f86a6f20d07f755651e8.tar.gz |
Merge branch 'create-branch-service-create-file' into 'master'
Fix CreateBranchService after Repository#commit_file was renamed to create_file
Closes #29687
See merge request !10081
-rw-r--r-- | app/services/create_branch_service.rb | 6 | ||||
-rw-r--r-- | spec/services/create_branch_service_spec.rb | 24 |
2 files changed, 27 insertions, 3 deletions
diff --git a/app/services/create_branch_service.rb b/app/services/create_branch_service.rb index b07338d500a..673ed02f952 100644 --- a/app/services/create_branch_service.rb +++ b/app/services/create_branch_service.rb @@ -25,12 +25,12 @@ class CreateBranchService < BaseService private def create_master_branch - project.repository.commit_file( + project.repository.create_file( current_user, '/README.md', '', message: 'Add README.md', - branch_name: 'master', - update: false) + branch_name: 'master' + ) end end diff --git a/spec/services/create_branch_service_spec.rb b/spec/services/create_branch_service_spec.rb new file mode 100644 index 00000000000..3f548688c20 --- /dev/null +++ b/spec/services/create_branch_service_spec.rb @@ -0,0 +1,24 @@ +require 'spec_helper' + +describe CreateBranchService, services: true do + let(:user) { create(:user) } + let(:service) { described_class.new(project, user) } + + describe '#execute' do + context 'when repository is empty' do + let(:project) { create(:project_empty_repo) } + + it 'creates master branch' do + service.execute('my-feature', 'master') + + expect(project.repository.branch_exists?('master')).to be_truthy + end + + it 'creates my-feature branch' do + service.execute('my-feature', 'master') + + expect(project.repository.branch_exists?('my-feature')).to be_truthy + end + end + end +end |