diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-04-12 20:16:26 +0000 |
|---|---|---|
| committer | Lin Jen-Shin <godfat@godfat.org> | 2017-04-13 19:47:00 +0800 |
| commit | 18fa43da403b1f8117c1586e292c2fb49b931217 (patch) | |
| tree | 9e3137408d4f8df8961a9b594cde638eccb8a624 | |
| parent | 467576d469370bc0d65150cde9aacad09482175c (diff) | |
| download | gitlab-ce-18fa43da403b1f8117c1586e292c2fb49b931217.tar.gz | |
Merge branch 'fix-preloading-merge_request_diff' into 'master'
Use preload to avoid Rails using JOIN
See merge request !10666
| -rwxr-xr-x | app/controllers/projects/merge_requests_controller.rb | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/fix-preloading-merge_request_diff.yml | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/controllers/projects/merge_requests_controller.rb b/app/controllers/projects/merge_requests_controller.rb index 5c1f7e69ee8..e3f3b14f993 100755 --- a/app/controllers/projects/merge_requests_controller.rb +++ b/app/controllers/projects/merge_requests_controller.rb @@ -39,7 +39,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController @collection_type = "MergeRequest" @merge_requests = merge_requests_collection @merge_requests = @merge_requests.page(params[:page]) - @merge_requests = @merge_requests.includes(merge_request_diff: :merge_request) + @merge_requests = @merge_requests.preload(merge_request_diff: :merge_request) @issuable_meta_data = issuable_meta_data(@merge_requests, @collection_type) if @merge_requests.out_of_range? && @merge_requests.total_pages != 0 diff --git a/changelogs/unreleased/fix-preloading-merge_request_diff.yml b/changelogs/unreleased/fix-preloading-merge_request_diff.yml new file mode 100644 index 00000000000..d38b6b0a707 --- /dev/null +++ b/changelogs/unreleased/fix-preloading-merge_request_diff.yml @@ -0,0 +1,4 @@ +--- +title: Fix bad query for PostgreSQL showing merge requests list +merge_request: 10666 +author: |