diff options
author | Valery Sizov <valery@gitlab.com> | 2017-06-01 12:07:06 +0300 |
---|---|---|
committer | Valery Sizov <valery@gitlab.com> | 2017-06-01 12:07:06 +0300 |
commit | b417fc0329ec10ccbaa1c282893f8710ff81db9d (patch) | |
tree | ebfe7a8f7155a2a3122e205a3a175a3d790ca71e | |
parent | 22acd28908f9779c5dd5cea0e41c014382209262 (diff) | |
download | gitlab-ce-b417fc0329ec10ccbaa1c282893f8710ff81db9d.tar.gz |
Fix rubocop in spec/helpers/diff_helper_spec.rb
-rw-r--r-- | spec/helpers/diff_helper_spec.rb | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/spec/helpers/diff_helper_spec.rb b/spec/helpers/diff_helper_spec.rb index 85093f799e9..855cbfb67f6 100644 --- a/spec/helpers/diff_helper_spec.rb +++ b/spec/helpers/diff_helper_spec.rb @@ -130,10 +130,14 @@ describe DiffHelper do end describe '#parallel_diff_discussions' do - it 'does not put comments on nonewline lines' do - discussion = {'abc_3_3' => 'comment'} + let(:discussion) { { 'abc_3_3' => 'comment' } } + let(:diff_file) { double(line_code: 'abc_3_3') } + + before do helper.instance_variable_set(:@grouped_diff_discussions, discussion) - diff_file = double(line_code: 'abc_3_3') + end + + it 'does not put comments on nonewline lines' do left = Gitlab::Diff::Line.new('\\nonewline', 'old-nonewline', 3, 3, 3) right = Gitlab::Diff::Line.new('\\nonewline', 'new-nonewline', 3, 3, 3) @@ -143,9 +147,6 @@ describe DiffHelper do end it 'puts comments on added lines' do - discussion = {'abc_3_3' => 'comment'} - helper.instance_variable_set(:@grouped_diff_discussions, discussion) - diff_file = double(line_code: 'abc_3_3') left = Gitlab::Diff::Line.new('\\nonewline', 'old-nonewline', 3, 3, 3) right = Gitlab::Diff::Line.new('new line', 'add', 3, 3, 3) |