diff options
author | Simon Knox <psimyn@gmail.com> | 2017-08-28 15:03:33 +1000 |
---|---|---|
committer | Gabriel Mazetto <brodock@gmail.com> | 2017-08-30 18:55:17 +0200 |
commit | dde498702d10fcfbd845f846dce16e3db40a8393 (patch) | |
tree | abff4dbe394a77085fa2f0afa62a07a0ee420594 | |
parent | 87530be766a7ae496660debab603a79cd9713e08 (diff) | |
download | gitlab-ce-dde498702d10fcfbd845f846dce16e3db40a8393.tar.gz |
fix transient test failures caused by wrong dropdown trigger
-rw-r--r-- | spec/features/snippets/notes_on_personal_snippets_spec.rb | 4 | ||||
-rw-r--r-- | spec/support/features/reportable_note_shared_examples.rb | 2 | ||||
-rw-r--r-- | spec/support/helpers/note_interaction_helpers.rb | 2 |
3 files changed, 3 insertions, 5 deletions
diff --git a/spec/features/snippets/notes_on_personal_snippets_spec.rb b/spec/features/snippets/notes_on_personal_snippets_spec.rb index d088739b5fc..50cbce925ab 100644 --- a/spec/features/snippets/notes_on_personal_snippets_spec.rb +++ b/spec/features/snippets/notes_on_personal_snippets_spec.rb @@ -93,9 +93,7 @@ describe 'Comments on personal snippets', :js, feature: true do it 'changes the text' do open_more_actions_dropdown(snippet_notes[0]) - page.within("#notes-list li#note_#{snippet_notes[0].id}") do - click_on 'Edit comment' - end + find('.js-note-edit').trigger('click') page.within('.current-note-edit-form') do fill_in 'note[note]', with: 'new content' diff --git a/spec/support/features/reportable_note_shared_examples.rb b/spec/support/features/reportable_note_shared_examples.rb index 27e079c01dd..5a4c0ac7cf7 100644 --- a/spec/support/features/reportable_note_shared_examples.rb +++ b/spec/support/features/reportable_note_shared_examples.rb @@ -31,7 +31,7 @@ shared_examples 'reportable note' do end def open_dropdown(dropdown) - dropdown.click + dropdown.find('.more-actions-toggle').trigger('click') dropdown.find('.dropdown-menu li', match: :first) end end diff --git a/spec/support/helpers/note_interaction_helpers.rb b/spec/support/helpers/note_interaction_helpers.rb index 551c759133c..86008698692 100644 --- a/spec/support/helpers/note_interaction_helpers.rb +++ b/spec/support/helpers/note_interaction_helpers.rb @@ -2,7 +2,7 @@ module NoteInteractionHelpers def open_more_actions_dropdown(note) note_element = find("#note_#{note.id}") - note_element.find('.more-actions').click + note_element.find('.more-actions-toggle').trigger('click') note_element.find('.more-actions .dropdown-menu li', match: :first) end end |