summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClement Ho <clemmakesapps@gmail.com>2017-09-07 22:46:25 +0000
committerSimon Knox <psimyn@gmail.com>2017-09-08 22:48:27 +1000
commit8ee57308be0aa81539bfea7398cac38817fa4ced (patch)
tree18b494d3f2d30c45434f26507cae63b9844d07d4
parent00976ff53eafd9ef655732034ec5371503ff5342 (diff)
downloadgitlab-ce-8ee57308be0aa81539bfea7398cac38817fa4ced.tar.gz
Merge branch '36638-select-project-to-create-issue-button-is-disconnected-from-dropdown-button' into 'master'
Normalize styles for empty-state group-level new issue/MR combo button Closes #36638 See merge request !13647
-rw-r--r--app/assets/stylesheets/framework/nav.scss23
-rw-r--r--app/views/shared/_new_project_item_select.html.haml2
-rw-r--r--changelogs/unreleased/36638-select-project-to-create-issue-button-is-disconnected-from-dropdown-button.yml5
3 files changed, 24 insertions, 6 deletions
diff --git a/app/assets/stylesheets/framework/nav.scss b/app/assets/stylesheets/framework/nav.scss
index d386ac5ba9c..5de72a66958 100644
--- a/app/assets/stylesheets/framework/nav.scss
+++ b/app/assets/stylesheets/framework/nav.scss
@@ -286,11 +286,7 @@
display: flex;
max-width: 350px;
overflow: hidden;
-
- @media(max-width: $screen-xs-max) {
- width: 100%;
- max-width: none;
- }
+ float: right;
.new-project-item-link {
white-space: nowrap;
@@ -303,6 +299,23 @@
}
}
+.empty-state .project-item-select-holder.btn-group {
+ float: none;
+ display: inline-block;
+
+ .btn {
+ // overrides styles applied to plain `.empty-state .btn`
+ margin: 10px 0;
+ max-width: 300px;
+ width: auto;
+
+ @media(max-width: $screen-xs-max) {
+ max-width: 250px;
+ }
+
+ }
+}
+
.new-project-item-select-button .fa-caret-down {
margin-left: 2px;
}
diff --git a/app/views/shared/_new_project_item_select.html.haml b/app/views/shared/_new_project_item_select.html.haml
index 96502d7ce93..2f9b8fb3039 100644
--- a/app/views/shared/_new_project_item_select.html.haml
+++ b/app/views/shared/_new_project_item_select.html.haml
@@ -1,5 +1,5 @@
- if any_projects?(@projects)
- .project-item-select-holder.btn-group.pull-right
+ .project-item-select-holder.btn-group
%a.btn.btn-new.new-project-item-link{ href: '', data: { label: local_assigns[:label] } }
= icon('spinner spin')
= project_select_tag :project_path, class: "project-item-select", data: { include_groups: local_assigns[:include_groups], order_by: 'last_activity_at', relative_path: local_assigns[:path] }, with_feature_enabled: local_assigns[:with_feature_enabled]
diff --git a/changelogs/unreleased/36638-select-project-to-create-issue-button-is-disconnected-from-dropdown-button.yml b/changelogs/unreleased/36638-select-project-to-create-issue-button-is-disconnected-from-dropdown-button.yml
new file mode 100644
index 00000000000..76c9c905590
--- /dev/null
+++ b/changelogs/unreleased/36638-select-project-to-create-issue-button-is-disconnected-from-dropdown-button.yml
@@ -0,0 +1,5 @@
+---
+title: Normalize styles for empty state combo button
+merge_request:
+author:
+type: fixed