diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2018-09-26 10:36:44 +0000 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2018-09-26 10:36:44 +0000 |
| commit | 194896f4509e0a23316389b4017c84ed99fc50fd (patch) | |
| tree | 91e7dfb196d7479e4d1d6146076927f3418250f1 | |
| parent | f1b4443762af085e416a205634319a66d9f77d41 (diff) | |
| download | gitlab-ce-194896f4509e0a23316389b4017c84ed99fc50fd.tar.gz | |
Defines Vue.js Expert Role
Currently we have a vue.js expert role that is not defined
By defining this role we can improve our Vue and Vuex code.
| -rw-r--r-- | doc/development/fe_guide/vue.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/development/fe_guide/vue.md b/doc/development/fe_guide/vue.md index f6cbd11042c..05db9ee9f66 100644 --- a/doc/development/fe_guide/vue.md +++ b/doc/development/fe_guide/vue.md @@ -221,6 +221,14 @@ const vm = mountComponent(Component, data); The main return value of a Vue component is the rendered output. In order to test the component we need to test the rendered output. [Vue][vue-test] guide's to unit test show us exactly that: +## Vue.js Expert Role +One should apply to be a Vue.js expert by opening an MR when the MR's they create and review show: +- Deep understanding of Vue and Vuex reactivy +- Vue and Vuex code are structured according to both official and our guidelines +- Full test coverage of a Vue and Vuex application +- Vuex code follows the [documented pattern](./vuex.md#actions-pattern-request-and-receive-namespaces) +- Knowledge about the existing Vue and Vuex codebase and existing reusable components + [vue-docs]: http://vuejs.org/guide/index.html [issue-boards]: https://gitlab.com/gitlab-org/gitlab-ce/tree/master/app/assets/javascripts/boards |