summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean McGivern <sean@mcgivern.me.uk>2017-07-27 12:10:24 +0000
committerSean McGivern <sean@mcgivern.me.uk>2017-07-27 12:10:24 +0000
commit77d0007704e2336349c2dcef4dd4858c81814ccb (patch)
tree9dd398480df5cb80e78ef9a5174b2338fe5ca863
parent4d05e85375b81d94ef828c8c5544bf62a5abc024 (diff)
parentcbfdc7e3b53c5443a82c78bc69c77ad000648973 (diff)
downloadgitlab-ce-77d0007704e2336349c2dcef4dd4858c81814ccb.tar.gz
Merge branch 'rc/35599-stop-the-bleeding-of-default_url_options' into 'master'
Ensure the overriding of Gitlab::Application.routes.default_url_options is only local See merge request !13125
-rw-r--r--spec/features/dashboard/issues_spec.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/spec/features/dashboard/issues_spec.rb b/spec/features/dashboard/issues_spec.rb
index 2a5ef08da60..ea7a9efc326 100644
--- a/spec/features/dashboard/issues_spec.rb
+++ b/spec/features/dashboard/issues_spec.rb
@@ -80,6 +80,8 @@ RSpec.describe 'Dashboard Issues', feature: true do
end
it 'shows the new issue page', js: true do
+ original_defaults = Gitlab::Application.routes.default_url_options
+
Gitlab::Application.routes.default_url_options = {
host: Capybara.current_session.server.host,
port: Capybara.current_session.server.port,
@@ -95,6 +97,8 @@ RSpec.describe 'Dashboard Issues', feature: true do
page.within('#content-body') do
expect(page).to have_selector('.issue-form')
end
+
+ Gitlab::Application.routes.default_url_options = original_defaults
end
end
end