summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouglas Barbosa Alexandre <dbalexandre@gmail.com>2019-01-25 17:53:56 +0000
committerDouglas Barbosa Alexandre <dbalexandre@gmail.com>2019-01-25 17:53:56 +0000
commitbf2fe35e2d65583022828d61766f7e63ca7d2670 (patch)
tree2605251dcd43749e1b4d91527d85d62823ca99c9
parentc73bf13d1785a04cb1d4b3c52bcf83988e67a832 (diff)
parent40bfa51e303377dd856c024f6e543937d2038a6b (diff)
downloadgitlab-ce-bf2fe35e2d65583022828d61766f7e63ca7d2670.tar.gz
Merge branch '56860-fix-spec-race-condition-upside-the-head' into 'master'
Fix a JS race in a spec Closes #56860 See merge request gitlab-org/gitlab-ce!24684
-rw-r--r--spec/features/projects/settings/user_changes_default_branch_spec.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/spec/features/projects/settings/user_changes_default_branch_spec.rb b/spec/features/projects/settings/user_changes_default_branch_spec.rb
index fcf05e04a5c..7dc18601f50 100644
--- a/spec/features/projects/settings/user_changes_default_branch_spec.rb
+++ b/spec/features/projects/settings/user_changes_default_branch_spec.rb
@@ -15,6 +15,9 @@ describe 'Projects > Settings > User changes default branch' do
let(:project) { create(:project, :repository, namespace: user.namespace) }
it 'allows to change the default branch', :js do
+ # Otherwise, running JS may overwrite our change to project_default_branch
+ wait_for_requests
+
select2('fix', from: '#project_default_branch')
page.within '#default-branch-settings' do