summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-08-30 18:50:06 +0000
committerFilipa Lacerda <filipa@gitlab.com>2017-08-30 18:50:06 +0000
commitc38d624b22bd0f19dca3c768a945244393863abc (patch)
tree2511668b201cd0d9589c4c83b8510f21c1e391be
parentd540d43e2d1dd20f81a736aab99f9d073a83e82a (diff)
parentcc81a40dccc64e66c464626a7af2003efe671dbc (diff)
downloadgitlab-ce-c38d624b22bd0f19dca3c768a945244393863abc.tar.gz
Merge branch 'fix-timeago-tooltip-attribute' into 'master'
Fix invalid attribute used for time-ago-tooltip component Closes #37163 See merge request !13899
-rw-r--r--app/assets/javascripts/issue_show/components/edited.vue2
-rw-r--r--spec/javascripts/issue_show/components/edited_spec.js10
2 files changed, 11 insertions, 1 deletions
diff --git a/app/assets/javascripts/issue_show/components/edited.vue b/app/assets/javascripts/issue_show/components/edited.vue
index d59e6d11032..992b7064c13 100644
--- a/app/assets/javascripts/issue_show/components/edited.vue
+++ b/app/assets/javascripts/issue_show/components/edited.vue
@@ -37,7 +37,7 @@ export default {
Edited
<time-ago-tooltip
v-if="updatedAt"
- placement="bottom"
+ tooltip-placement="bottom"
:time="updatedAt"
/>
<span
diff --git a/spec/javascripts/issue_show/components/edited_spec.js b/spec/javascripts/issue_show/components/edited_spec.js
index a0d0750ae34..2061def699b 100644
--- a/spec/javascripts/issue_show/components/edited_spec.js
+++ b/spec/javascripts/issue_show/components/edited_spec.js
@@ -46,4 +46,14 @@ describe('edited', () => {
expect(editedComponent.$el.querySelector('.author_link')).toBeFalsy();
expect(editedComponent.$el.querySelector('time')).toBeTruthy();
});
+
+ it('renders time ago tooltip at the bottom', () => {
+ const editedComponent = new EditedComponent({
+ propsData: {
+ updatedAt: '2017-05-15T12:31:04.428Z',
+ },
+ }).$mount();
+
+ expect(editedComponent.$el.querySelector('time').dataset.placement).toEqual('bottom');
+ });
});