summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Greiling <mike@pixelcog.com>2018-12-03 16:06:35 +0000
committerMike Greiling <mike@pixelcog.com>2018-12-03 16:06:35 +0000
commit2859e8d54f948184ac489afea995c65ed0ca325c (patch)
tree1f7580cdb8294ad73c81bff1b6496ae753b78073
parent04a6ed6970505be661b7481225f8f3592940bdb0 (diff)
parent8d57227041381c403db28cf1aa000f40899eec73 (diff)
downloadgitlab-ce-2859e8d54f948184ac489afea995c65ed0ca325c.tar.gz
Merge branch '53400-unstar-icon-button-is-misaligned' into 'master'
Resolve "unstar icon button is misaligned" Closes #53400 See merge request gitlab-org/gitlab-ce!23444
-rw-r--r--app/assets/javascripts/star.js4
-rw-r--r--changelogs/unreleased/53400-unstar-icon-button-is-misaligned.yml5
2 files changed, 7 insertions, 2 deletions
diff --git a/app/assets/javascripts/star.js b/app/assets/javascripts/star.js
index 007b83e1927..9af5d5b23cb 100644
--- a/app/assets/javascripts/star.js
+++ b/app/assets/javascripts/star.js
@@ -23,11 +23,11 @@ export default class Star {
if (isStarred) {
$starSpan.removeClass('starred').text(s__('StarProject|Star'));
$startIcon.remove();
- $this.prepend(spriteIcon('star-o'));
+ $this.prepend(spriteIcon('star-o', 'icon'));
} else {
$starSpan.addClass('starred').text(__('Unstar'));
$startIcon.remove();
- $this.prepend(spriteIcon('star'));
+ $this.prepend(spriteIcon('star', 'icon'));
}
})
.catch(() => Flash('Star toggle failed. Try again later.'));
diff --git a/changelogs/unreleased/53400-unstar-icon-button-is-misaligned.yml b/changelogs/unreleased/53400-unstar-icon-button-is-misaligned.yml
new file mode 100644
index 00000000000..b393795f491
--- /dev/null
+++ b/changelogs/unreleased/53400-unstar-icon-button-is-misaligned.yml
@@ -0,0 +1,5 @@
+---
+title: 'Fix: Unstar icon button is misaligned'
+merge_request: 23444
+author:
+type: fixed