Raise NotImplementedError on required Service Methods

2 files changed, 9 insertions, 10 deletions

diff --git a/app/models/project_services/slack_service.rb b/app/models/project_services/slack_service.rb
index abbc780dc1a..33ec6817694 100644
--- a/app/models/project_services/slack_service.rb
+++ b/app/models/project_services/slack_service.rb
@@ -21,16 +21,16 @@ class SlackService < Service
     'A team communication tool for the 21st century'
   end
 
-  def to_param
-    'slack'
-  end
-
   def help
     'This service sends notifications to your Slack channel.<br/>
     To setup this Service you need to create a new <b>"Incoming webhook"</b> in your Slack integration panel,
     and enter the Webhook URL below.'
   end
 
+  def to_param
+    'slack'
+  end
+
   def fields
     default_fields =
       [
diff --git a/app/models/service.rb b/app/models/service.rb
index 40cd9b861f0..c55d3c7c75a 100644
--- a/app/models/service.rb
+++ b/app/models/service.rb
@@ -58,23 +58,22 @@ class Service < ActiveRecord::Base
   end
 
   def title
-    # implement inside child
+    raise NotImplementedError
   end
 
   def description
-    # implement inside child
+    raise NotImplementedError
   end
 
   def help
-    # implement inside child
+    ''
   end
 
   def to_param
-    # implement inside child
+    raise NotImplementedError
   end
 
   def fields
-    # implement inside child
     []
   end
 
@@ -99,7 +98,7 @@ class Service < ActiveRecord::Base
   end
 
   def execute(data)
-    # implement inside child
+    raise NotImplementedError
   end
 
   def test(data)