diff options
| author | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-04 05:37:12 +0000 |
|---|---|---|
| committer | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-04 05:37:12 +0000 |
| commit | 957744dab4297f66dc70c1727fe2cf5282d2ea5a (patch) | |
| tree | ce4e1d4722e43316b2c2b6af316446285151dc8d /CHANGELOG.md | |
| parent | a04a451fca4c077709bb60bbe05b04b306fae167 (diff) | |
| parent | b1b51b774bffd64b9117296d46052b8bbc44f430 (diff) | |
| download | gitlab-ce-957744dab4297f66dc70c1727fe2cf5282d2ea5a.tar.gz | |
Merge branch 'gitlab-ce-cleanup-global-namespace-javascript' into 'master'
Cleaned up global namespace JS
Original MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6229
## What does this MR do?
Cleans up javascript global namespace by moving the functions that were previously on the window.doSomething namespace
## Are there points in the code the reviewer needs to double check?
None that I'm aware of
## Why was this MR needed?
Improves code maintainability and deals with some of the technical debt
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [X] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #19661
See merge request !7208
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index a209dba0950..dd6b4e0ba11 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ entry. - Fix mobile layout issues in admin user overview page !7087 - Fix HipChat notifications rendering (airatshigapov, eisnerd) - Remove 'Edit' button from wiki edit view !7143 (Hiroyuki Sato) +- Cleaned up global namespace JS !19661 (Jose Ivan Vargas) - Refactor Jira service to use jira-ruby gem - Improved todos empty state - Add hover to trash icon in notes !7008 (blackst0ne) |