diff options
author | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-04 03:53:17 +0000 |
---|---|---|
committer | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-04 03:53:17 +0000 |
commit | 3a8a7c1251cef4098ffbc54718ba21736c5e2800 (patch) | |
tree | f582d8ecfde3250ae4b34da26079c1a8a1c81a23 /CHANGELOG.md | |
parent | 630c40b9a2b14c96254a21bea23835e28ae6140a (diff) | |
parent | 99a000da34d5f4b07548602d6503eb60e00344de (diff) | |
download | gitlab-ce-3a8a7c1251cef4098ffbc54718ba21736c5e2800.tar.gz |
Merge branch 'fix-invalid-filename-eslint' into 'master'
eslint: Fix invalid filename validation
Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced.
```
/builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6
2:1 error Filename 'gl_field_error.js.es6' does not match the naming convention filenames/match-regex
```
This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$`
This new regex allows the following filenames to pass as valid:
- `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js`
- `gl_foo_bar.js` which base name translates to `gl_foo_bar`
- `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific)
See merge request !7281
Diffstat (limited to 'CHANGELOG.md')
0 files changed, 0 insertions, 0 deletions