diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-07-03 22:31:43 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-07-11 15:09:21 -0700 |
| commit | af3727b34a3e61668ffca8dc4db85e3c57ff2cc8 (patch) | |
| tree | 0bcdece17af6a14e7e5793f7204ca29a34fc535f /CHANGELOG | |
| parent | 734e44ee79590be6d9f01ca3e815304221a5c88d (diff) | |
| download | gitlab-ce-af3727b34a3e61668ffca8dc4db85e3c57ff2cc8.tar.gz | |
Optimize system note visibility checking by hiding notes that
have been fully redacted and contain cross-project references.
The previous implementation relied on Note#cross_reference_not_visible_for?,
which essentially tries to render all the Markdown references in a system note
and only displays the note if the user can see the referring project. But this
duplicated the work that Banzai::NotesRenderer was doing already. Instead, for
each note we render, we memoize the number of visible user references and
use it later if it is available.
Improves #19273
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 79ee72e330c..41fd3c8d22b 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -4,6 +4,7 @@ v 8.10.0 (unreleased) - Fix commit builds API, return all builds for all pipelines for given commit. !4849 - Replace Haml with Hamlit to make view rendering faster. !3666 - Refactor repository paths handling to allow multiple git mount points + - Optimize system note visibility checking by memoizing the visible reference count !5070 - Add Application Setting to configure default Repository Path for new projects - Wrap code blocks on Activies and Todos page. !4783 (winniehell) - Align flash messages with left side of page content !4959 (winniehell) |