diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2016-08-19 14:48:06 +0000 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2016-08-19 14:48:06 +0000 |
| commit | 39820d8013aa550470180ac609ad70c40098d035 (patch) | |
| tree | 8be034f05b9d6aaaa4dc0c23ce0a86137da6f339 /CHANGELOG | |
| parent | e5840a4d9b6d696f26cd1956c5aace2507f3abf0 (diff) | |
| parent | 9a8b29e3ee3fc88f536f104a4ff962c0e435f3f4 (diff) | |
| download | gitlab-ce-39820d8013aa550470180ac609ad70c40098d035.tar.gz | |
Merge branch 'cs-async-branch-dropdown' into 'master'
Load branch dropdowns asynchronously for cherry pick and revert dialogs
## Why was this MR needed and what does it do?
Previously every commit page was loading every branch onto the page twice, once each for the Cherry Pick and Revert modal dialogs. Most of the time they're never used, so that's a bit of a waste.
This loads them asynchronously by modifying the existing ref switcher code to also work for the branch selectors. This is better for performance.
## Are there points in the code the reviewer needs to double check?
Make sure Cherry Picking and Reverting still work (from my tests they seem to be fine).
## What are the relevant issue numbers?
Fixes #20108.
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
cc: @iamphill @jschatz1
See merge request !5607
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index fec7c56c32d..ef14c290615 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -74,6 +74,7 @@ v 8.11.0 (unreleased) - Fix devise deprecation warnings. - Check for 2FA when using Git over HTTP and only allow PersonalAccessTokens as password in that case !5764 - Update version_sorter and use new interface for faster tag sorting + - Load branches asynchronously in Cherry Pick and Revert dialogs. - Optimize checking if a user has read access to a list of issues !5370 - Store all DB secrets in secrets.yml, under descriptive names !5274 - Fix syntax highlighting in file editor |