diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-10-05 11:38:58 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-10-05 11:38:58 +0000 |
| commit | c9396bc7c5b7b55fd01ec63279f5ab4223c0a184 (patch) | |
| tree | fa6fb2a485ec6286530b06770a79c6af2ff2b260 /CHANGELOG | |
| parent | 6d74e474aba6f1480ae3ba69aa4e29f1e033bc60 (diff) | |
| parent | 16ed9b6129daf51a296d4576580c5f232d043db6 (diff) | |
| download | gitlab-ce-c9396bc7c5b7b55fd01ec63279f5ab4223c0a184.tar.gz | |
Merge branch 'test-improve-gitlab-identifier' into 'master'
Refactor Gitlab::Identifier
## What does this MR do?
This refactors `Gitlab::Identifier` so that it:
1. Has tests
2. Caches output in an instance variable to reduce queries
3. Uses only a single query to find a user by an SSH key, instead of 2
## Why was this MR needed?
This code was untested and would execute more SQL queries than needed.
See merge request !6680
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 49b15c1773b..d424fbe43b8 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -48,6 +48,7 @@ v 8.13.0 (unreleased) - Optimize GitHub importing for speed and memory - API: expose pipeline data in builds API (!6502, Guilherme Salazar) - Notify the Merger about merge after successful build (Dimitris Karakasilis) + - Reduce queries needed to find users using their SSH keys when pushing commits - Fix broken repository 500 errors in project list - Close todos when accepting merge requests via the API !6486 (tonygambone) - Changed Slack service user referencing from full name to username (Sebastian Poxhofer) |