diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-07-27 09:37:33 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-07-27 09:37:33 +0000 |
| commit | 260102b288bffa9048c3fccfc49cc1c44dfc1095 (patch) | |
| tree | 5a0c12d8bf97b10eebd8f50406a48433a74e8e56 /CHANGELOG | |
| parent | f88bb5a52e95ad81c1b9314523cc02ade0e2834a (diff) | |
| parent | 774997e964ca7724a37d3f17a75f3224f8ce896c (diff) | |
| download | gitlab-ce-260102b288bffa9048c3fccfc49cc1c44dfc1095.tar.gz | |
Merge branch '14584-remove-routes-that-we-do-not-use-anymore' into 'master'
Resolve "Remove routes that we do not use anymore"
_Originally opened at !4059 by @strzibny._
- - -
## What does this MR do?
> I tried to clean up the routes as mentioned in #14584
I used the following script and manually verified the changes: https://gist.github.com/strzibny/4ccbda7dcf67ef6719dcb047014e1ea7
After this patch, the script still gives me the following routes:
Unused routes (7): oauth/authorizations#show doorkeeper/tokens#create doorkeeper/tokens#revoke oauth/applications#edit oauth/applications#show doorkeeper/token_info#show omniauth_callbacks#(?-mix:(?!))
Here is a relevant code from doorkeeper on drawing these routes: https://github.com/doorkeeper-gem/doorkeeper/blob/5ea4575863781940fe6996692c6b41f2ad71d90e/lib/doorkeeper/rails/routes.rb#L25
## What are the relevant issue numbers?
Closes #14584.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5499
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index cf75bee4348..6d96993510b 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -6,6 +6,7 @@ v 8.11.0 (unreleased) - Fix of 'Commits being passed to custom hooks are already reachable when using the UI' - Add support for using RequestStore within Sidekiq tasks via SIDEKIQ_REQUEST_STORE env variable - Limit git rev-list output count to one in forced push check + - Clean up unused routes (Josef Strzibny) - Add green outline to New Branch button. !5447 (winniehell) - Retrieve rendered HTML from cache in one request - Nokogiri's various parsing methods are now instrumented |